Add support for int64 for CSVParser#417
Merged
hcho3 merged 2 commits intodmlc:masterfrom Jun 27, 2018
haojin2:csv_int64
Merged
Conversation
Contributor
Author
|
@tqchen @piiswrong @hcho3 ping for review. |
hcho3
approved these changes
Jun 27, 2018
Contributor
hcho3
left a comment
hcho3
left a comment
There was a problem hiding this comment.
All look good to me. Can you take a look at the single comment I left on the code? Thanks.
| // If DType is all other types | ||
| } else { | ||
| LOG(FATAL) << "Only float32 and int32 are supported for the time being"; | ||
| LOG(FATAL) << "Only float32, int32, and int64 are supported for the time being"; |
Contributor
There was a problem hiding this comment.
Is it reasonable to assume that int is 32-bit? I think we may want to replace int in CSVParser with int32_t. So for instance, the lines
typedef ParserFactoryReg<uint32_t, int> Reg32int;
typedef ParserFactoryReg<uint64_t, int> Reg64int;would become
typedef ParserFactoryReg<uint32_t, int32_t> Reg32int32;
typedef ParserFactoryReg<uint64_t, int32_t> Reg64int32;
Contributor
Author
There was a problem hiding this comment.
Good catch, I'll make the change and update my PR.
Contributor
Author
|
@hcho3 should be good for merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as title.
This PR adds support for parsing int64 data type in dmlc-core, so that mxnet could also support this type in CSVIter