Revert "Allow large array operation in MXNet (#348)"#357
Revert "Allow large array operation in MXNet (#348)"#357eric-haibin-lin merged 1 commit intodmlc:masterfrom
Conversation
This reverts commit d68d369.
|
I believe this change have nothing to do nnvm::NodeEntry data type |
|
I believe @azai91 meant compilation-errors like this http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/incubator-mxnet/detail/PR-12674/1/pipeline |
|
Unfortunately, I do feel these are warnings that need to be fixed in the corresponding code (because loop variable index_t is being used). We could monkey patch the index of NodeEntry to int64_t, that will, however, increase the space requirement by 3 * 4 bytes and looks like a temporary solution just to suppress these warnings |
|
@apeforest could you propose the patch again, fix the problems and merge it into mxnet? |
|
@szha Sure, I will submit the PR again together with the change in MXNet so it will not break MXNet. I do have a PR (apache/mxnet#11742) in MXNet but I am currently fixing a unit test failure in GPU. |
This reverts commit d68d369.
This does not build as tvm nnvm::NodeEntry cannot accept input. tvm needs to be updated first.