Skip to content
This repository was archived by the owner on Aug 11, 2020. It is now read-only.

Revert "Allow large array operation in MXNet (#348)"#357

Merged
eric-haibin-lin merged 1 commit intodmlc:masterfrom
azai91:revert/d68d3
Sep 28, 2018
Merged

Revert "Allow large array operation in MXNet (#348)"#357
eric-haibin-lin merged 1 commit intodmlc:masterfrom
azai91:revert/d68d3

Conversation

@azai91
Copy link
Copy Markdown
Contributor

@azai91 azai91 commented Sep 28, 2018

This reverts commit d68d369.

This does not build as tvm nnvm::NodeEntry cannot accept input. tvm needs to be updated first.

@eric-haibin-lin eric-haibin-lin merged commit 839bcc8 into dmlc:master Sep 28, 2018
@eric-haibin-lin eric-haibin-lin mentioned this pull request Sep 28, 2018
7 tasks
@szha
Copy link
Copy Markdown
Member

szha commented Sep 28, 2018

@apeforest @tqchen

@tqchen
Copy link
Copy Markdown
Member

tqchen commented Sep 28, 2018

I believe this change have nothing to do nnvm::NodeEntry data type

@szha
Copy link
Copy Markdown
Member

szha commented Sep 28, 2018

@tqchen
Copy link
Copy Markdown
Member

tqchen commented Sep 28, 2018

Unfortunately, I do feel these are warnings that need to be fixed in the corresponding code (because loop variable index_t is being used).

We could monkey patch the index of NodeEntry to int64_t, that will, however, increase the space requirement by 3 * 4 bytes and looks like a temporary solution just to suppress these warnings

@szha
Copy link
Copy Markdown
Member

szha commented Sep 28, 2018

@apeforest could you propose the patch again, fix the problems and merge it into mxnet?

@apeforest
Copy link
Copy Markdown
Contributor

@szha Sure, I will submit the PR again together with the change in MXNet so it will not break MXNet. I do have a PR (apache/mxnet#11742) in MXNet but I am currently fixing a unit test failure in GPU.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants