Javascript: Add iterable instance to Diff for destructuring. #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves google#39 It can be useful to extract `Diff` elements using destructuring assignment. For example: ```js const a = dmp.diff_main('abc', 'ab123c', false); const [eq, str] = a[0]; ``` Because the `Diff` object is not an array, however, this is not possible, even though it acts like an array. In this patch a new `Symbol.iterator` method is added to the `Diff` class so that this pattern can be used. Props: @JackuB, @GrosSacASac, @TheSpyder Co-authored-by: Cyril Walle <cyril.walle@protonmail.com>
Merged
|
oh I was about to add this to my PR 😂 thank you 👍 |
Owner
Author
we were talking back and forth and I figured that instead of asking you to do so I might as well just push it out. what's the point of having a fork if you don't push through your own work? 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves google#39
It can be useful to extract
Diffelements using destructuringassignment. For example:
Because the
Diffobject is not an array, however, this is notpossible, even though it acts like an array.
In this patch a new
Symbol.iteratormethod is added to theDiffclass so that this pattern can be used.
Props: @JackuB, @GrosSacASac, @TheSpyder