-
Notifications
You must be signed in to change notification settings - Fork 35
fix(NumberFormat): ensure -0 is displayed as 0 when formatted as currency #4788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
langz
approved these changes
Mar 20, 2025
tujoworker
pushed a commit
that referenced
this pull request
Mar 21, 2025
## [10.69.0](v10.68.1...v10.69.0) (2025-03-21) ### ✨ Features * **Field.SelectCountry:** add `autoComplete` support ([#4781](#4781)) ([176760b](176760b)) * **Field.SelectCountry:** enhance value type ([#4782](#4782)) ([a51ec61](a51ec61)) * **Forms:** add `CountryISO` as the value type to Field.SelectCountry ([#4791](#4791)) ([b8491ed](b8491ed)) * **Forms:** add `Field.SelectCurrency` and `Value.SelectCurrency` ([#4770](#4770)) ([279d03e](279d03e)) * **InfoCard:** add `stretch` property and don't stretch by default ([#4765](#4765)) ([d7c850d](d7c850d)) * **NumberFormat:** use component's translation for invalid aria text ([#4763](#4763)) ([f446639](f446639)) * **Table:** add view transition support to inserted table rows (accordion) ([#4764](#4764)) ([29273c8](29273c8)) ### 📝 Documentation * add link to localization docs in portal tools menu ([#4762](#4762)) ([d39353b](d39353b)) * **DatePicker:** add rationale behind why `correctInvalidDate` is not on by default ([#4776](#4776)) ([c414463](c414463)) * **Field.SelectCountry:** improve event arguments ([#4784](#4784)) ([644f9e8](644f9e8)) * **Forms:** add example on how to use `onInput` ([#4792](#4792)) ([2294b68](2294b68)) ### 🐛 Bug Fixes * **Forms:** don't show Wizard step error on small screens for the same step ([#4774](#4774)) ([74afa5e](74afa5e)) * **Forms:** enhance typing for `FieldBlock` and `useFieldProps` ([#4785](#4785)) ([64070a6](64070a6)) * **Forms:** ensure Wizard does not show invalid error ([#4786](#4786)) ([e5f913c](e5f913c)) * **NumberFormat:** ensure -0 is displayed as 0 when formatted as currency ([#4788](#4788)) ([aa02d37](aa02d37)), closes [#4691](#4691)
Member
Author
|
🎉 This PR is included in version 10.69.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
tujoworker
added a commit
that referenced
this pull request
May 13, 2025
…alues (#5116) - Motivation: https://dnb-it.slack.com/archives/CMXABCHEY/p1747123226048919 - Related #4788
tujoworker
pushed a commit
that referenced
this pull request
May 19, 2025
## [10.74.0](v10.73.2...v10.74.0) (2025-05-19) ### ✨ Features * **DatePicker:** add year navigation to calendar ([#4978](#4978)) ([b927430](b927430)) * **Field.Date:** add `yearNavigation` ([#5121](#5121)) ([65928d0](65928d0)) * **Forms:** add `preventUncommittedChanges` in Form.Isolation to show error during submit after user input ([#5102](#5102)) ([fbc5402](fbc5402)), closes [#5005](#5005) [#5127](#5127) * **Forms:** add `resetAfterCommit` to Form.Isolation ([#5127](#5127)) ([353271d](353271d)) * **Iterate.PushContainer:** deprecate `requireCommit` in favor of `preventUncommitedChanges` ([#5134](#5134)) ([9596abb](9596abb)) ### 🐛 Bug Fixes * **Button:** bold font weight issue when `type="submit"` on iPhone ([#5147](#5147)) ([ac12151](ac12151)) * **Checkbox:** add support for `preventDefault` in onClick ([#4768](#4768)) ([c03a930](c03a930)) * **DatePicker:** cancel and reset functionality ([#5021](#5021)) ([3db9c0e](3db9c0e)) * **Drawer:** bottom containerPlacement on small screen ([#5123](#5123)) ([1afada9](1afada9)) * **DrawerList:** refactor TypeScript ([#4687](#4687)) ([5697c2c](5697c2c)) * **Dropdown:** fix `React.ReactNode` support for `title` prop ([#5124](#5124)) ([9d2b653](9d2b653)) * **Field.Selection:** apply correct `width` to prevent label wrapping ([#5120](#5120)) ([a2d7928](a2d7928)) * **Field.Toggle, Field.Boolean:** add support for `preventDefault` in onClick for `checkbox` variant ([#5117](#5117)) ([a34700f](a34700f)), closes [#4768](#4768) * **Forms:** ensure Form.Isolation does work within a Form.Section ([#5142](#5142)) ([0db7aa3](0db7aa3)) * **Forms:** support `required` in Field.Selection with `dropdown` variant ([#5106](#5106)) ([d1202b9](d1202b9)) * **Heading:** warning when increasing heading to be `h2` when previous sibling is `h1` ([#4914](#4914)) ([393e765](393e765)) * **InputMasked:** allow value 0 when `disallowLeadingZeroes` is set ([#4918](#4918)) ([c08e51a](c08e51a)), closes [/github.com/dnbexperience/eufemia/blob/a564953ecd7d7aeb25f9dc603456ba52ea91049f/packages/dnb-eufemia/src/components/input-masked/InputMaskedHooks.js#L348](https://github.com/dnbexperience//github.com/dnbexperience/eufemia/blob/a564953ecd7d7aeb25f9dc603456ba52ea91049f/packages/dnb-eufemia/src/components/input-masked/InputMaskedHooks.js/issues/L348) * **NumberFormat:** render minus sign correctly for negative decimal values ([#5116](#5116)) ([b1b31d4](b1b31d4)), closes [#4788](#4788)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR #4691 and more details.