feat(Field.Currency): defaults to disallowing leading zeroes #5000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
1 task
langz
commented
Apr 24, 2025
packages/dnb-eufemia/src/extensions/forms/Field/Currency/__tests__/Currency.test.tsx
Outdated
Show resolved
Hide resolved
langz
commented
Apr 24, 2025
packages/dnb-eufemia/src/extensions/forms/Field/Currency/__tests__/Currency.test.tsx
Outdated
Show resolved
Hide resolved
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
langz
commented
Apr 24, 2025
packages/dnb-eufemia/src/extensions/forms/Field/Currency/__tests__/Currency.test.tsx
Outdated
Show resolved
Hide resolved
langz
force-pushed
the
feat/disallow-leading-zeroes-field-currency
branch
from
43fca6a to
0b6454b
Compare
langz
force-pushed
the
feat/disallow-leading-zeroes-field-currency
branch
from
0b6454b to
a32eada
Compare
tujoworker
approved these changes
May 14, 2025
Member
tujoworker
left a comment
tujoworker
left a comment
There was a problem hiding this comment.
Nice! But I think we should first merge #4918 and then test this one again, properly.
tujoworker
requested changes
May 15, 2025
Member
tujoworker
left a comment
tujoworker
left a comment
There was a problem hiding this comment.
Following today’s meeting, we decided to postpone setting this as the default for this field for some time. Just to get a better understanding of how the changed made in #4918 will work out for projects using it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4918