This repository was archived by the owner on Jul 18, 2025. It is now read-only.
Sort machine ls output by machine name#87
Merged
bfirsh merged 3 commits intodocker-archive-public:masterfrom Dec 12, 2014
Merged
Sort machine ls output by machine name#87bfirsh merged 3 commits intodocker-archive-public:masterfrom
machine ls output by machine name#87bfirsh merged 3 commits intodocker-archive-public:masterfrom
Conversation
Signed-off-by: Guillaume Giamarchi <guillaume.giamarchi@gmail.com>
Contributor
There was a problem hiding this comment.
A better name for this might be HostListItem or something like that. "State" is an overloaded term – I was confused about what this had to do with the host state (running, stopped, etc).
I would also argue that this struct should live in commands.go too – it is part of the functionality of the machine ls command.
Contributor
|
Looks great apart from a naming niggle. Thanks! |
Signed-off-by: Guillaume Giamarchi <guillaume.giamarchi@gmail.com>
Signed-off-by: Guillaume Giamarchi <guillaume.giamarchi@gmail.com>
ggiamarchi
force-pushed
the
machine-ls-sort
branch
from
98334ba to
d8921ee
Compare
Contributor
Author
|
👍 Fixed |
Contributor
|
Awesome, thanks! |
bfirsh
added a commit
that referenced
this pull request
Dec 12, 2014
Sort `machine ls` output by machine name
superseb
pushed a commit
to superseb/machine
that referenced
this pull request
Dec 4, 2020
…ister_subscription Remove register Microsoft.Subscription from Azure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment in the
machine lsoutput, the order of appearance of the machines is not predictable due to go routine implementation.This pull request fix this, sorting machine by names (case insensitive).