Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

Fix #68. Homedir is now detected same as Docker.#88

Merged
bfirsh merged 1 commit into
docker-archive-public:masterfrom
MSOpenTech:homedir
Dec 12, 2014
Merged

Fix #68. Homedir is now detected same as Docker.#88
bfirsh merged 1 commit into
docker-archive-public:masterfrom
MSOpenTech:homedir

Conversation

@jeffmendoza
Copy link
Copy Markdown
Contributor

Will need to rebase on #83 when that is merged.

Signed-off-by: Jeff Mendoza <jeffmendoza@live.com>
Comment thread drivers/utils.go
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be filepath.Join(GetHomeDir(), ".docker", "public-key.json") so the correct separator is used on Windows?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per #83

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it should, #83 has those fixes.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotchya. Let's hope it merges cleanly. ;)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it won't will it. Oh well.

bfirsh added a commit that referenced this pull request Dec 12, 2014
Fix #68. Homedir is now detected same as Docker.
@bfirsh bfirsh merged commit ee98043 into docker-archive-public:master Dec 12, 2014
@bfirsh
Copy link
Copy Markdown
Contributor

bfirsh commented Dec 12, 2014

Thanks!

@bfirsh bfirsh mentioned this pull request Dec 12, 2014
@jeffmendoza jeffmendoza deleted the homedir branch December 12, 2014 18:48
tomeon pushed a commit to tomeon/machine that referenced this pull request May 9, 2018
superseb pushed a commit to superseb/machine that referenced this pull request Dec 4, 2020
…esolve_nsg_ref

Relocate resolveNSGReference in Azure node driver
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants