This repository was archived by the owner on Nov 27, 2023. It is now read-only.
Add Stop command on the gRPC side.
#99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-crone
reviewed
May 18, 2020
| rpc Exec(ExecRequest) returns (ExecResponse); | ||
| } | ||
|
|
||
| message Port { |
moby/backend.go
Outdated
| } | ||
|
|
||
| func (ms *mobyService) Stop(ctx context.Context, containerName string) error { | ||
| timeout := 1 * time.Second |
Contributor
There was a problem hiding this comment.
1 second might be too short. What does docker/cli and docker/compose use?
Contributor
Author
There was a problem hiding this comment.
timeout is a parameter to stop now
silvin-lubecki
approved these changes
May 18, 2020
Contributor
silvin-lubecki
left a comment
silvin-lubecki
left a comment
There was a problem hiding this comment.
Just a fix on the options and a test to add, otherwise LGTM
rumpl
force-pushed
the
feat-stop
branch
2 times, most recently
from
a428ab2 to
c4a04ca
Compare
chris-crone
approved these changes
May 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a mixed PR and I am really sorry about it, it contains:
--allflag todocker psallparameter in the interfaces and in the gRPC layerStopcommand to stop a running container (only implemented it in moby, still needs to be implemented for ACI).I just realized there is an inconsistency in the naming,
docker rmcalls theDeletemethod, we would need to create a new methodRemovefor this and not useDeleteonrm.