Add LICENSE (copy of docker/docker's Apache-2.0 file)#103
Add LICENSE (copy of docker/docker's Apache-2.0 file)#103thaJeztah merged 1 commit intodocker-archive:masterfrom
Conversation
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM, thanks!
ping @andrewhsu @friism
|
Interesting; @andrewhsu this also needs to go into the 17.06.x branch |
|
Reposting my response from packaging issue:
|
Isn't that what this item in the license is included for? Wondering though, given that some components are taken from other repositories, Reading that, does that imply that any file that has been modified (due to |
|
Do we have a timeline for this? When are we going to have a LICENSE for docker-ce? |
|
The Windows community is blocked having no newer Docker CLI binary than 17.10 available for months. The chocolatey package "docker" using direct downloads from download.docker.com/win/static suffers from it. People ask me to update, but I cannot help. There are people with enterprise Windows machines using other Hypervisors than VirtualBox (Docker Toolbox) and Hyper-V (Docker 4 Windows). Installing Toolbox where you only need the Docker CLI is a big overhead. I looked for a way to compile docker.exe for a specific release version, but it's not possible to share such binary. The docker/cli repo has no tags and branches, so it's unusable. Only source of truth is this repo's components/cli subfolder. But without a license it's impossible to distribute such binary for the Chocolatey community. |
|
There’s a license inside the components/cli directory, so I wonder if that’s enough to build just the cli. |
Bump Golang to 1.9.5 Upstream-commit: f169b1e Component: packaging
[18.09 backport] Fix double "unix://" scheme in TestInfoAPIWarnings Upstream-commit: 299385de7fb930e7e805faf960dc66e9cadd8ad4 Component: engine
|
Any chance of this being revisited? |
Signed-off-by: Tianon Gravi <admwiggin@gmail.com>
Bump Golang to 1.9.5 Upstream-commit: f169b1e Component: packaging
Bump Golang to 1.9.5
|
wait with merging of this one; I got approval for the docker/docker-ce-packaging repo, but this one was not yet discussed (FWIW, we're moving away from using this mono-repo in our build/packaging pipelines, so it will be obsolete in the near future) |
Approval should be done in docker/docker-ce-packaging
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
let's bring this one in; ignoring CI as the Jenkins config was moved, and CI is not testing this, other than a DCO check, and the commit has a DCO sign-off
This repository was missing a license, but since it's been created mostly from bits of
github.com/docker/docker, I figured that license was probably appropriate for this top-level (since the individual vendored directories should have theirLICENSEfiles intact anyhow).A quick
diffto show that it's 100% identical: