Ensure service images get default tag and print familiar strings #13
Conversation
nishanttotla
left a comment
nishanttotla
left a comment
There was a problem hiding this comment.
@mlaventure given these changes are in the client package, do we need to import them into docker/cli as well to make sure they get into the release?
I'm not sure how the process works at the moment because we have multiple repos, but docker/cli uses its own vendored version of the moby/moby client package.
Let me know if I can help in any way.
cc @andrewhsu
|
I'd say it's fine that way, |
|
@mlaventure I'm talking about this https://github.com/docker/docker-ce/blob/master/components/cli/vendor/github.com/docker/docker/client/service_create.go Shouldn't this file also be updated, along with the corresponding vendored versions of files changed in this PR? |
|
@nishanttotla if It needs to be updated their should be an equivalent cherry-pick for it from |
|
@mlaventure that's what I was asking about. The process seems unclear right now. I'll open a vendor PR. |
|
LGTM this one will go in first before the related ticket #32 |
Add systemd scripts Upstream-commit: 9c1135d Component: packaging
[18.06] Bump swarmkit to include task reaper fixes and more metrics. Upstream-commit: 73ca638f393dab7277f1a1797b24ab1777138a13 Component: engine
Add systemd scripts Upstream-commit: 9c1135d Component: packaging
Add systemd scripts
Ensure service images get default tag and print familiar strings
3 participants
Cherry pick of moby/moby#33279 which fixed docker/cli#79 (AKA docker service ls/ps is not truncating digests anymore)