Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

Conversation

@tiborvass
Copy link
Contributor

@tiborvass tiborvass commented Jun 3, 2017

Follow up to #23

Will rebase once #23 merged.

The commit to review is f148100. It's a cherry-pick of docker/cli#154

@mlaventure
Copy link
Contributor

It creates docs/yaml/generate.sh without execution permission on my machine when I clone your branch

@tiborvass tiborvass force-pushed the man-yaml-scripts branch 3 times, most recently from 868616b to 83f0ba8 Compare June 5, 2017 19:28
Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdlinville
Copy link
Contributor

LGTM, the output looks great!

@tiborvass tiborvass changed the title [WIP] Add scripts and targets for manpages and yamldocs Add scripts and targets for manpages and yamldocs Jun 5, 2017
Signed-off-by: Tibor Vass <tibor@docker.com>
(cherry picked from commit ff615dbc4d01b0115e4658ee1a0ed6809b5f88ae)
@andrewhsu
Copy link
Contributor

LGTM

@andrewhsu andrewhsu merged commit c6dd1af into docker-archive:17.06 Jun 5, 2017
@mavenugo mavenugo mentioned this pull request Jun 6, 2017
23 tasks
andrewhsu added a commit that referenced this pull request Jun 24, 2017
also have deb pkg conflict docker-engine
Upstream-commit: 405d7d9
Component: packaging
@andrewhsu andrewhsu modified the milestone: 17.06.0 Jul 12, 2017
docker-jenkins pushed a commit that referenced this pull request Jul 16, 2018
[18.06] Fix flakyness in TestDockerNetworkInternalMode
Upstream-commit: 8308a17b6a7e51e87b1e4e6d99313011a10e117f
Component: engine
silvin-lubecki pushed a commit to silvin-lubecki/docker-ce that referenced this pull request Jan 30, 2020
also have deb pkg conflict docker-engine
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants