[18.01] Changelog for 18.01 by jose-bigio · Pull Request #379 · docker-archive/docker-ce

jose-bigio · 2018-01-03T22:36:40Z

Signed-off-by: jose-bigio jose.bigio@docker.com

vieux · 2018-01-04T00:13:39Z

+### ---Triage---
+
+* Legacy images replacement with multi-arch ones on AArch64 [moby/moby#35773](https://github.com/moby/moby/pull/35773)
+* Vendor: update archive/tar [moby/moby#35728](https://github.com/moby/moby/pull/35728)


I'd remove all the vendor

vieux · 2018-01-04T00:14:02Z

+
+### ---Triage---
+
+* Legacy images replacement with multi-arch ones on AArch64 [moby/moby#35773](https://github.com/moby/moby/pull/35773)


i'd remove this one

vieux · 2018-01-04T00:14:54Z

+* Return errors from client in stack deploy configs [docker/cli#757](https://github.com/docker/cli/pull/757)
+- Fix description of filter flag in prune commands [docker/cli#774](https://github.com/docker/cli/pull/774)
+ Add kubernetes support to docker/cli [docker/cli#721](https://github.com/docker/cli/pull/721)
+- Fix #512 Bash autocompletion works incorrect with inspect [docker/cli#713](https://github.com/docker/cli/pull/713)


i'd remove "Fix #512"

vieux · 2018-01-04T00:16:05Z

thanks @jose-bigio , as I said I would remove all the vendor update and I would use

``

around flags and command such as docker exec

thaJeztah · 2018-01-03T23:29:42Z

+
+### Builder
+
+* Remove dead code and redundant build tags [moby/moby#35823](https://github.com/moby/moby/pull/35823)


Not really worth mentioning

thaJeztah · 2018-01-03T23:31:50Z

+### Builder
+
+* Remove dead code and redundant build tags [moby/moby#35823](https://github.com/moby/moby/pull/35823)
+* Skip container ID remapping, if the file is overlayfs whiteout. [moby/moby#35822](https://github.com/moby/moby/pull/35822)


perhaps;

Fix files not being deleted during if user-namespaces are enabled

thaJeztah · 2018-01-03T23:33:02Z

+
+* Remove dead code and redundant build tags [moby/moby#35823](https://github.com/moby/moby/pull/35823)
+* Skip container ID remapping, if the file is overlayfs whiteout. [moby/moby#35822](https://github.com/moby/moby/pull/35822)
+- Fix environ substitutions in `docker commit --change ...` [moby/moby#35582](https://github.com/moby/moby/pull/35582)


perhaps:

Add support for expanding environment-variables in `docker commit --change ...`

thaJeztah · 2018-01-03T23:33:34Z

+
+### Client
+
+* Remove reference to non-existing "stack config" command [docker/cli#765](https://github.com/docker/cli/pull/765)


no need to mention this one

thaJeztah · 2018-01-03T23:36:20Z

+* Remove reference to non-existing "stack config" command [docker/cli#765](https://github.com/docker/cli/pull/765)
+* Return errors from client in stack deploy configs [docker/cli#757](https://github.com/docker/cli/pull/757)
+- Fix description of filter flag in prune commands [docker/cli#774](https://github.com/docker/cli/pull/774)
+ Add kubernetes support to docker/cli [docker/cli#721](https://github.com/docker/cli/pull/721)


This should probably be under a Experimental header, and we need to make clear it's only for docker stack commands; perhaps;

Add experimental support for docker stack commands on kubernetes

(better suggestions welcome)

thaJeztah · 2018-01-04T00:18:03Z

+* Carry #35609 (remove import of opencontainers/runc in windows) [moby/moby#35788](https://github.com/moby/moby/pull/35788)
+* Devmapper: Log fstype and mount options during mount error [moby/moby#35732](https://github.com/moby/moby/pull/35732)
+* Windows: Case-insensitive filename matching against builder cache [moby/moby#35793](https://github.com/moby/moby/pull/35793)
+- Fix race conditions in libcontainerd process handling [moby/moby#35809](https://github.com/moby/moby/pull/35809)


This was already back ported to 17.12

thaJeztah · 2018-01-04T00:18:33Z

+
+* Carry #35609 (remove import of opencontainers/runc in windows) [moby/moby#35788](https://github.com/moby/moby/pull/35788)
+* Devmapper: Log fstype and mount options during mount error [moby/moby#35732](https://github.com/moby/moby/pull/35732)
+* Windows: Case-insensitive filename matching against builder cache [moby/moby#35793](https://github.com/moby/moby/pull/35793)


This was already back ported to 17.12

thaJeztah · 2018-01-04T00:20:12Z

+
+### ---Triage---
+
+* Legacy images replacement with multi-arch ones on AArch64 [moby/moby#35773](https://github.com/moby/moby/pull/35773)


no need to mention this one

thaJeztah · 2018-01-04T00:20:43Z

+### ---Triage---
+
+* Legacy images replacement with multi-arch ones on AArch64 [moby/moby#35773](https://github.com/moby/moby/pull/35773)
+* Vendor: update archive/tar [moby/moby#35728](https://github.com/moby/moby/pull/35728)


Already back ported to 17.12, and not worth mentioning

thaJeztah · 2018-01-04T00:23:26Z

+### --Delete-- (For review only)
+- Fixed typo DEREPCATED -> DEPRECATED. [moby/moby#35899](https://github.com/moby/moby/pull/35899)
+- Fix typo in link [docker/cli#759](https://github.com/docker/cli/pull/759)
+* Bump API version to 1.36 [moby/moby#35738](https://github.com/moby/moby/pull/35738)


reverted in #378

note that API version bumps should normally be included in the changelog. We can copy the exact changes from the API history; https://github.com/docker/docker-ce/blob/17.12/components/engine/docs/api/version-history.md#v135-api-changes

There's no API changes in 18.01, so not for this release 😄

Everything under the delete header I intended to delete.
Do you agree with that?

Yes, they are all ok to remove (just pointed out the API things for future change logs 😅 )

thaJeztah · 2018-01-04T00:25:57Z

Oops, race condition; left some comments on now outdated lines

@vieux some of the vendor updates included fixes that are worth mentioning; I pointed those out in my review 😅

jose-bigio · 2018-01-04T00:30:14Z

Thanks for all the comments @thaJeztah I'll make sure to make the changes!

andrewhsu

if you could squish commits, LGTM

Signed-off-by: jose-bigio <jose.bigio@docker.com>

thaJeztah · 2018-01-04T01:31:24Z

+
+### Runtime
+
+* Re-validate Mounts on container start [moby/moby#35833](https://github.com/moby/moby/pull/35833)


Looks like you missed this one; #379 (comment)

thaJeztah · 2018-01-04T01:31:51Z

+* Re-validate Mounts on container start [moby/moby#35833](https://github.com/moby/moby/pull/35833)
+- Fix overlay2 storage driver inside a user namespace [moby/moby#35794](https://github.com/moby/moby/pull/35794)
+* Zfs: fix busy error on container stop [moby/moby#35674](https://github.com/moby/moby/pull/35674)
+- Fix #35843 regression on health check workingdir [moby/moby#35845](https://github.com/moby/moby/pull/35845)


looks like you missed this one #379 (comment)

…gin-ls-filter Add metric plugins to zsh completion for `plugin ls --filter capability` Upstream-commit: 915b18bdc9f08e279bb7c1044c4c86be80168ad6 Component: cli

[18.09 backport] Fix unmount redeclaration on darwin Upstream-commit: 10ca83725886b3804b5ba53f26678877104ec96d Component: engine

[19.03 backport] RPM spec: remove -ce suffix from distribution_based_engine JSON Upstream-commit: 146a09e4a18213e28cad8743e10c1639ac7827cc Component: packaging

jose-bigio changed the title ~~Changelog for 18.01~~ [18.01] Changelog for 18.01 Jan 3, 2018

jose-bigio added this to the 18.01.0 milestone Jan 3, 2018

andrewhsu requested review from thaJeztah and vieux January 3, 2018 23:08

vieux reviewed Jan 4, 2018

View reviewed changes

thaJeztah suggested changes Jan 4, 2018

View reviewed changes

andrewhsu approved these changes Jan 4, 2018

View reviewed changes

Changelog for 18.01

a971796

Signed-off-by: jose-bigio <jose.bigio@docker.com>

jose-bigio force-pushed the 18.01_changelog branch from 6d25974 to a971796 Compare January 4, 2018 01:23

andrewhsu merged commit f0e6477 into docker-archive:18.01 Jan 4, 2018

thaJeztah reviewed Jan 4, 2018

View reviewed changes

docker-jenkins pushed a commit that referenced this pull request Sep 24, 2019

Merge pull request #379 from kolyshkin/18.09-backport-38372

a530713

[18.09 backport] Fix unmount redeclaration on darwin Upstream-commit: 10ca83725886b3804b5ba53f26678877104ec96d Component: engine


		### ---Triage---

		* Legacy images replacement with multi-arch ones on AArch64 [moby/moby#35773](https://github.com/moby/moby/pull/35773)


		### Builder

		* Remove dead code and redundant build tags [moby/moby#35823](https://github.com/moby/moby/pull/35823)


		### Client

		* Remove reference to non-existing "stack config" command [docker/cli#765](https://github.com/docker/cli/pull/765)


		### Runtime

		* Re-validate Mounts on container start [moby/moby#35833](https://github.com/moby/moby/pull/35833)

Conversation

jose-bigio commented Jan 3, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vieux commented Jan 4, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thaJeztah commented Jan 4, 2018

Uh oh!

jose-bigio commented Jan 4, 2018

Uh oh!

andrewhsu left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants