Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

[18.03] skip DockerTrustSuite tests for 18.03#437

Merged
andrewhsu merged 2 commits into
docker-archive:18.03from
andrewhsu:t
Feb 22, 2018
Merged

[18.03] skip DockerTrustSuite tests for 18.03#437
andrewhsu merged 2 commits into
docker-archive:18.03from
andrewhsu:t

Conversation

@andrewhsu
Copy link
Copy Markdown
Contributor

@andrewhsu andrewhsu commented Feb 22, 2018

Seeing failures in DockerTrustSuite:

...
FAIL: docker_cli_build_test.go:4224: DockerTrustSuite.TestTrustedBuildTagFromReleasesRole
FAIL: docker_cli_build_test.go:4255: DockerTrustSuite.TestTrustedBuildTagIgnoresOtherDelegationRoles
FAIL: docker_cli_create_test.go:295: DockerTrustSuite.TestTrustedCreate
FAIL: docker_cli_create_test.go:331: DockerTrustSuite.TestTrustedCreateFromBadTrustServer
FAIL: docker_cli_create_test.go:321: DockerTrustSuite.TestTrustedIsolatedCreate
FAIL: docker_cli_pull_trusted_test.go:25: DockerTrustSuite.TestTrustedIsolatedPull
FAIL: docker_cli_pull_trusted_test.go:85: DockerTrustSuite.TestTrustedOfflinePull
FAIL: docker_cli_pull_trusted_test.go:14: DockerTrustSuite.TestTrustedPull
FAIL: docker_cli_pull_trusted_test.go:48: DockerTrustSuite.TestTrustedPullFromBadTrustServer
FAIL: docker_cli_pull_trusted_test.go:135: DockerTrustSuite.TestTrustedPullReadsFromReleasesRole
FAIL: docker_cli_push_test.go:284: DockerTrustSuite.TestTrustedPush
FAIL: docker_cli_push_test.go:368: DockerTrustSuite.TestTrustedPushWithIncorrectPassphraseForNonRoot
FAIL: docker_cli_run_test.go:3143: DockerTrustSuite.TestTrustedRun
FAIL: docker_cli_run_test.go:3172: DockerTrustSuite.TestTrustedRunFromBadTrustServer
...
OOPS: 20 passed, 14 FAILED
...

This PR will address it by ignoring those tests until they can be ported to the new testing thing.

This PR fixes the same notary mismatch issue from 17.10, 17.11, 17.12, 18.01, and 18.02 caused by updated stderr output from docker/cli#636 Fix stdout and errors in image/trust

This pr is duplicate of #397 [18.02] skip DockerTrustSuite tests for 18.02

With cherry-pick 9d7b9c2 and 1a2098c:

$ git cherry-pick -s -x 9d7b9c2 1a2098c

No conflicts.

seemethere and others added 2 commits February 21, 2018 16:23
Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
(cherry picked from commit 4e81e4f)
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
(cherry picked from commit ec6b0a1)
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
(cherry picked from commit fbfeceb)
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
(cherry picked from commit e357107)
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
(cherry picked from commit 9d7b9c2)
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
(cherry picked from commit 250b84e)
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
(cherry picked from commit d256539)
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
(cherry picked from commit 5742bd3)
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
(cherry picked from commit 1a2098c)
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
@andrewhsu andrewhsu added this to the 18.03.0 milestone Feb 22, 2018
@andrewhsu andrewhsu requested review from cyli, endophage and n4ss February 22, 2018 00:28
Copy link
Copy Markdown

@jose-bigio jose-bigio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu
Copy link
Copy Markdown
Contributor Author

Looks like DockerTrustSuite tests all pass, but have an error with TestAttachAfterDetach which will be addressed with #439

@n4ss
Copy link
Copy Markdown
Contributor

n4ss commented Feb 22, 2018

LGTM!

I will port them to docker cli.

@andrewhsu andrewhsu merged commit 5c06a61 into docker-archive:18.03 Feb 22, 2018
@andrewhsu andrewhsu deleted the t branch February 22, 2018 02:30
docker-jenkins pushed a commit that referenced this pull request Jan 16, 2020
…ker_py_test

[19.03 backport] docker-py: skip broken ImageCollectionTest::test_pull_multiple, and re-enable fixed tests
Upstream-commit: 077f0939881ed69e105a4e6bc5daea74e91f3dbc
Component: engine
silvin-lubecki pushed a commit to silvin-lubecki/docker-ce that referenced this pull request Jan 31, 2020
[18.03] skip DockerTrustSuite tests for 18.03
docker-jenkins pushed a commit that referenced this pull request Mar 12, 2020
Update README to include Ubuntu 19.10
Upstream-commit: 486c47f
Component: packaging
akrasnov-drv pushed a commit to drivenets/docker-ce that referenced this pull request Apr 23, 2023
…ker-archive#435)

* * Verification scripts for rpm
* Verification scripts for deb
* Integrated verify step in release-packaging Jenkinsfile

Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>

* Merge pull request docker-archive#439 from seemethere/remove_f31

[ce-19.03] ci: Remove fedora 31 arm64

* Revert "Merge pull request docker-archive#439 from seemethere/remove_f31"

This reverts commit 700e7a6b75938d96ab587b889077ec6a3dec9963, reversing
changes made to caa1930f1f60c52afccd1ff06882c6e7c2200440.

* [ce-19.03] ci: Re-add saveS3 (docker-archive#437)

[ce-19.03] ci: Re-add saveS3
akrasnov-drv pushed a commit to drivenets/docker-ce that referenced this pull request Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants