Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

[WIP] [18.03] backport test changes#502

Closed
thaJeztah wants to merge 6 commits into
docker-archive:18.03from
thaJeztah:18.03-backport-test-changes
Closed

[WIP] [18.03] backport test changes#502
thaJeztah wants to merge 6 commits into
docker-archive:18.03from
thaJeztah:18.03-backport-test-changes

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

Cherry-picks for 18.03 of

yongtang and others added 6 commits April 10, 2018 11:41
This fix migrates volumes tests in integration-cli to api tests
in integration/

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
(cherry picked from commit d896f87)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This fix migrates several docker rm tests to api tests

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
(cherry picked from commit 6bd4f48)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
…ntainer

This fix moves helper functions containerIsStopped and
containerIsInState to integration/internal/container,
so that they could be used outside of integration/container.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
(cherry picked from commit eda311c)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This fix is a minor enhancement to replace several ContainerCreate with
helper funcs of `container.Create` in tests.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
(cherry picked from commit 6ad4720)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This fix migrates export tests in integration-cli to api tests.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
(cherry picked from commit 4e702cf)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
```
docker build -f Dockerfile.e2e -t moby-e2e .
docker run -v /var/run/docker.sock:/var/run/docker.sock \
           -e TEST_INTEGRATION_DIR=/tests/integration/container \
           -e DOCKER_API_VERSION=1.36 moby-e2e
```

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
(cherry picked from commit 18dd1d9)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@andrewhsu andrewhsu added this to the 18.03.1 milestone Apr 12, 2018
Copy link
Copy Markdown
Contributor

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah changed the title [18.03] backport test changes [WIP] [18.03] backport test changes Apr 17, 2018
@thaJeztah
Copy link
Copy Markdown
Member Author

We can close this one in favour of #512 if that goes green

@thaJeztah
Copy link
Copy Markdown
Member Author

closing, because #512 was merged

@thaJeztah thaJeztah closed this Apr 17, 2018
@thaJeztah thaJeztah deleted the 18.03-backport-test-changes branch April 17, 2018 22:06
@andrewhsu andrewhsu removed this from the 18.03.1 milestone Apr 18, 2018
docker-jenkins pushed a commit that referenced this pull request Oct 20, 2020
Add Ubuntu 20.10 "Groovy Gorilla"
Upstream-commit: 57ae892
Component: packaging
akrasnov-drv pushed a commit to drivenets/docker-ce that referenced this pull request Apr 23, 2023
…roovy-gorilla

Add Ubuntu 20.10 "Groovy Gorilla"
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants