Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

[18.03] Fix Windows layer leak when write fails#508

Merged
andrewhsu merged 1 commit into
docker-archive:18.03from
thaJeztah:18.03-backport-LayerLeak
Apr 12, 2018
Merged

[18.03] Fix Windows layer leak when write fails#508
andrewhsu merged 1 commit into
docker-archive:18.03from
thaJeztah:18.03-backport-LayerLeak

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Apr 11, 2018

backport of moby/moby#36728 for 18.03

git checkout -b 18.03-backport-LayerLeak upstream/18.03
git cherry-pick -s -S -x -Xsubtree=components/engine 1f28844d7869609f371ab2a7881e4488a79a7e27
git push -u origin 18.03-backport-LayerLeak

no conflicts

@darstahl @thaJeztah
Fix Windows layer leak when write fails
d8b4bd5 
Signed-off-by: Darren Stahl <darst@microsoft.com>
(cherry picked from commit 1f28844d7869609f371ab2a7881e4488a79a7e27)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 18.03.1 milestone Apr 11, 2018
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Apr 11, 2018

ping @carlfischer1 @johnstep @salah-khan PTAL

johnstep
johnstep approved these changes Apr 11, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@johnstep johnstep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu andrewhsu merged commit 7118075 into docker-archive:18.03 Apr 12, 2018
@thaJeztah thaJeztah deleted the 18.03-backport-LayerLeak branch April 12, 2018 01:23
@thaJeztah thaJeztah mentioned this pull request Jun 6, 2018
Closed
silvin-lubecki pushed a commit to silvin-lubecki/docker-ce that referenced this pull request Jan 31, 2020
@andrewhsu
Merge pull request docker-archive#508 from thaJeztah/18.03-backport-L…
384268c 
…ayerLeak

[18.03] Fix Windows layer leak when write fails
docker-jenkins pushed a commit that referenced this pull request Nov 5, 2020
@thaJeztah
Merge pull request #508 from thaJeztah/carry_365
9e03bed 
Do not "Bind" docker "To" containerd (carry #365)
Upstream-commit: 0786df7
Component: packaging
docker-jenkins pushed a commit that referenced this pull request May 19, 2021
@thaJeztah
Merge pull request #508 from thaJeztah/carry_365
e36f2e0 
Do not "Bind" docker "To" containerd (carry #365)
Upstream-commit: e60fba7b4e4875aededaaf4f316601cffb72f226
Component: engine
akrasnov-drv pushed a commit to drivenets/docker-ce that referenced this pull request Apr 23, 2023
@thaJeztah
Merge pull request docker-archive#508 from thaJeztah/carry_365
0786df7 
Do not "Bind" docker "To" containerd (carry docker-archive#365)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@johnstep johnstep johnstep approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

18.03.1

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah @johnstep @andrewhsu @darstahl