Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

[18.03] backport authz buffer fix#509

Merged
andrewhsu merged 1 commit into
docker-archive:18.03from
cpuguy83:18.03_backport_authz_buffer_fix_36595
Apr 19, 2018
Merged

[18.03] backport authz buffer fix#509
andrewhsu merged 1 commit into
docker-archive:18.03from
cpuguy83:18.03_backport_authz_buffer_fix_36595

Conversation

@cpuguy83
Copy link
Copy Markdown
Contributor

@cpuguy83 cpuguy83 commented Apr 12, 2018

When the authz response buffer limit is hit, perform a flush.
This prevents excessive buffer sizes, especially on large responses
(e.g. /containers//archive or /containers//export).

Backports moby/moby#36595 @ 74f8e47352e71aad4015d8d9dea8f16e7a055863
Which is a fix for moby/moby#36576

git cherry-pick -x -s -Xsubtree=components/engine 74f8e47352e71aad4015d8d9dea8f16e7a055863

@anusha-ragunathan
Copy link
Copy Markdown
Contributor

anusha-ragunathan commented Apr 12, 2018

LGTM

Replacing assert with github.com/stretchr/testify/require is easier for now.
Long term, moby/moby#36507 needs to be backported.

@jose-bigio jose-bigio changed the title 18.03 backport authz buffer fix [18.03] backport authz buffer fix Apr 12, 2018
@jose-bigio jose-bigio added this to the 18.03.1 milestone Apr 12, 2018
@thaJeztah
Copy link
Copy Markdown
Member

#513 backports moby/moby#36507

When the authz response buffer limit is hit, perform a flush.
This prevents excessive buffer sizes, especially on large responses
(e.g. `/containers/<id>/archive` or `/containers/<id>/export`).

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
(cherry picked from commit 74f8e47352e71aad4015d8d9dea8f16e7a055863)
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the 18.03_backport_authz_buffer_fix_36595 branch from a167c22 to 60dc869 Compare April 18, 2018 23:29
@thaJeztah
Copy link
Copy Markdown
Member

rebased to get the gotestyourself changes in

@andrewhsu andrewhsu requested a review from vdemeester April 19, 2018 03:37
Copy link
Copy Markdown
Contributor

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

looks like a clean cherry-pick to me

@andrewhsu andrewhsu merged commit 76cbc5d into docker-archive:18.03 Apr 19, 2018
silvin-lubecki pushed a commit to silvin-lubecki/docker-ce that referenced this pull request Jan 31, 2020
…thz_buffer_fix_36595

[18.03] backport authz buffer fix
docker-jenkins pushed a commit that referenced this pull request Mar 24, 2021
Add "procps" to daemon "Recommends" (for "docker top")
Upstream-commit: 120831d
Component: packaging
akrasnov-drv pushed a commit to drivenets/docker-ce that referenced this pull request Apr 23, 2023
Add "procps" to daemon "Recommends" (for "docker top")
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants