Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

[18.03] Adds a unit test for plugin request timeout#510

Closed
thaJeztah wants to merge 1 commit into
docker-archive:18.03from
thaJeztah:18.03-backport-add_plugin_timeout_test
Closed

[18.03] Adds a unit test for plugin request timeout#510
thaJeztah wants to merge 1 commit into
docker-archive:18.03from
thaJeztah:18.03-backport-add_plugin_timeout_test

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Apr 16, 2018

backport of moby/moby#36493 for 18.03

git checkout -b 18.03-backport-add_plugin_timeout_test upstream/18.03
git cherry-pick -s -S -x -Xsubtree=components/engine 7ca971fb495e4de4aa4455964625974464d86920
git push -u origin 18.03-backport-add_plugin_timeout_test

no conflicts

@cpuguy83 @thaJeztah
Adds a unit test for plugin request timeout
440c251 
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
(cherry picked from commit 7ca971f)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@anusha-ragunathan
Copy link
Copy Markdown
Contributor

anusha-ragunathan commented Apr 16, 2018

LGTM

@thaJeztah thaJeztah added this to the 18.03.1 milestone Apr 16, 2018
@thaJeztah thaJeztah mentioned this pull request Apr 17, 2018
Merged
cpuguy83
cpuguy83 approved these changes Apr 17, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Apr 17, 2018

This was included in #512 for 18.03.x

@thaJeztah thaJeztah closed this Apr 17, 2018
@thaJeztah thaJeztah deleted the 18.03-backport-add_plugin_timeout_test branch April 17, 2018 23:00
@andrewhsu andrewhsu removed this from the 18.03.1 milestone Apr 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@cpuguy83 cpuguy83 cpuguy83 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah @anusha-ragunathan @cpuguy83 @andrewhsu