Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

[18.06] bump ver 18.06.3#584

Merged
andrewhsu merged 1 commit into
docker-archive:18.06from
andrewhsu:18063
Feb 19, 2019
Merged

[18.06] bump ver 18.06.3#584
andrewhsu merged 1 commit into
docker-archive:18.06from
andrewhsu:18063

Conversation

@andrewhsu
Copy link
Copy Markdown
Contributor

No description provided.

@andrewhsu andrewhsu requested review from a team and thaJeztah February 19, 2019 21:54
@thaJeztah
Copy link
Copy Markdown
Member

full diff: v18.06.2-ce...4167aa5

thaJeztah
thaJeztah previously approved these changes Feb 19, 2019
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we might want to mention the packaging fix

Comment thread CHANGELOG.md
https://docs.docker.com/engine/deprecated/ where you can find the target removal dates

## 18.06.3-ce (2019-02-19)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to mention the packaging-fix in this release?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, sorry this is PR is WIP. i'll add words.

@andrewhsu andrewhsu changed the title [18.06] bump ver 18.06.3 WIP [18.06] bump ver 18.06.3 Feb 19, 2019
@thaJeztah
Copy link
Copy Markdown
Member

oh, right, so we'll need docker-archive/engine#156 to be pulled in as well first I guess?

@thaJeztah thaJeztah dismissed their stale review February 19, 2019 22:02

see discussion

Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
@andrewhsu andrewhsu changed the title WIP [18.06] bump ver 18.06.3 [18.06] bump ver 18.06.3 Feb 19, 2019
@andrewhsu
Copy link
Copy Markdown
Contributor Author

@thaJeztah stuff is now more up to date: v18.06.2-ce...18.06

and i've added words

@andrewhsu andrewhsu requested a review from ahh-docker February 19, 2019 23:01
Copy link
Copy Markdown
Contributor

@corbin-coleman corbin-coleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu andrewhsu merged commit d7080c1 into docker-archive:18.06 Feb 19, 2019
@andrewhsu andrewhsu deleted the 18063 branch February 28, 2019 02:40
@andrewhsu andrewhsu added this to the 18.06.3 milestone Mar 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants