Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

[WIP][19.03] Vendor Libnetwork 48f8463 to 19.03#193

Closed
mavenugo wants to merge 1 commit intodocker-archive:19.03from
mavenugo:1903_vendor_ln
Closed

[WIP][19.03] Vendor Libnetwork 48f8463 to 19.03#193
mavenugo wants to merge 1 commit intodocker-archive:19.03from
mavenugo:1903_vendor_ln

Conversation

@mavenugo
Copy link
Copy Markdown

@mavenugo mavenugo commented Apr 7, 2019

This commit brings in moby/libnetwork#2356 and moby/libnetwork#2357. Adds a workaround for a WS2016 HNS race issue by serializing the L2 Table programming across networks.

Signed-off-by: Madhu Venugopal madhu@docker.com

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@mavenugo mavenugo requested a review from thaJeztah April 7, 2019 16:54
@thaJeztah thaJeztah changed the title Vendor Libnetwork 48f8463 to 19.03 [WIP][19.03] Vendor Libnetwork 48f8463 to 19.03 Apr 7, 2019
@thaJeztah
Copy link
Copy Markdown
Member

marking this "WIP" in case we can still fast-forward

@selansen
Copy link
Copy Markdown

selansen commented Apr 7, 2019

with below error can we still move forward ?

17:06:24 
17:06:24  M vendor/github.com/docker/libnetwork/netutils/utils_linux.go
17:06:24 
17:06:24 Please vendor your package with github.com/LK4D4/vndr.```

@thaJeztah
Copy link
Copy Markdown
Member

hm, no; we need to fix that

Signed-off-by: Madhu Venugopal <madhu@docker.com>
@mavenugo
Copy link
Copy Markdown
Author

mavenugo commented Apr 7, 2019

@selansen @thaJeztah It was a silly issue... resolved the vendoring issue. PTAL.

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Copy Markdown
Member

let's not merge yet, pending #193 (comment) / moby#39018

Copy link
Copy Markdown

@selansen selansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Copy Markdown
Member

19.03 branch was updated and already includes this now; closing this one.

Thanks!

@thaJeztah thaJeztah closed this Apr 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants