Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

Conversation

@thaJeztah
Copy link
Member

full diff: moby/libnetwork@e7933d4...55685ba

changes included:

- moby/libnetwork#2382 Backporting PR 2069 to bump_18.09
  - backport of https://github.com/docker/libnetwork#2069 Rolling back the port configs if failed to programIngress()
- moby/libnetwork#2363 [18.09] align dependencies with engine 18.09
- moby/libnetwork#2400 [18.09 backport] Fix TestValidRemoteDriver GetCapabilities errors
- moby/libnetwork#2391 [18.09 backport] Correctly clean up --config-only networks
  - backport of moby/libnetwork#2373
  - fixes moby#35101
- moby/libnetwork#2392 [18.09 backport] remove gosimple - package is gone and it's not important

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 18.09.9 milestone Jul 23, 2019
@thaJeztah
Copy link
Member Author

Janky failing on a flaky https://jenkins.dockerproject.org/job/Docker-PRs/55009/console

00:06:39 FAIL: docker_cli_run_test.go:1792: DockerSuite.TestRunInteractiveWithRestartPolicy
00:06:39 
00:06:39 assertion failed: 
00:06:39 Command:  /usr/local/cli/docker run -i --name test-inter-restart --restart=always busybox sh
00:06:39 ExitCode: 0
00:06:39 Error:    <nil>
00:06:39 Stdout:   
00:06:39 Stderr:   
00:06:39 
00:06:39 Failures:
00:06:39 ExitCode was 0 expected 11

@thaJeztah
Copy link
Member Author

ping @kolyshkin PTAL

Copy link

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolyshkin kolyshkin merged commit e8c623b into docker-archive:18.09 Jul 25, 2019
@thaJeztah thaJeztah deleted the 18.09_bump_libnetwork2 branch July 25, 2019 19:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants