[19.03] bump swarmkit to 4fb9e961aba635f0240a140e89ece6d6c2082585 (bump_v19.03)

[thaJeztah]

full diff: moby/swarmkit@961ec3a...4fb9e96

included:

• [19.03 backport] Only update non-terminal tasks on node removal moby/swarmkit#2873 [19.03 backport] Only update non-terminal tasks on node removal
  • backport of Only update non-terminal tasks on node removal. moby/swarmkit#2867 Only update non-terminal tasks on node removal

[thaJeztah]

@dperny @dani-docker @kolyshkin PTAL

[thaJeztah]

WindowsRS1 is a flaky test; https://jenkins.dockerproject.org/job/Docker-PRs-WoW-RS1/26097/console

01:43:53 FAIL: docker_cli_start_test.go:190: DockerSuite.TestStartReturnCorrectExitCode
01:43:53 
01:43:53 docker_cli_start_test.go:200:
01:43:53     c.Assert(exitCode, checker.Equals, 12, check.Commentf("out: %s", out))
01:43:53 ... obtained int = 125
01:43:53 ... expected int = 12
01:43:53 ... out: time="2019-07-30T01:43:53Z" level=error msg="error waiting for container: EOF" 
01:43:53 

Janky; https://jenkins.dockerproject.org/job/Docker-PRs/55091/console

01:52:59 FAIL: docker_api_swarm_test.go:292: DockerSwarmSuite.TestAPISwarmLeaderElection
01:52:59 
01:52:59 Creating a new daemon
01:52:59 [d33633282af82] waiting for daemon to start
01:52:59 [d33633282af82] daemon started
01:52:59 
01:52:59 Creating a new daemon
01:52:59 [d652ea0e2209d] waiting for daemon to start
01:52:59 [d652ea0e2209d] daemon started
01:52:59 
01:52:59 Creating a new daemon
01:52:59 [d2311585af671] waiting for daemon to start
01:52:59 [d2311585af671] daemon started
01:52:59 
01:52:59 [d33633282af82] Stopping daemon
01:52:59 [d33633282af82] exiting daemon
01:52:59 [d33633282af82] Daemon stopped
01:52:59 Waiting for election to occur...
01:52:59 assertion failed: error is not nil: Error response from daemon: rpc error: code = DeadlineExceeded desc = context deadline exceeded: [d652ea0e2209d] (*Daemon).GetNode: NodeInspectWithRaw("ly9njv6l2dcvh384ft0cyaz1c") failed
01:52:59 waited for 20.000971802s (out of 30s)
01:52:59 [d652ea0e2209d] Stopping daemon
01:52:59 [d652ea0e2209d] exiting daemon
01:52:59 [d652ea0e2209d] Daemon stopped
01:52:59 [d2311585af671] Stopping daemon
01:52:59 [d2311585af671] exiting daemon
01:52:59 [d2311585af671] Daemon stopped

...

02:15:17 FAIL: docker_cli_swarm_test.go:1129: DockerSwarmSuite.TestSwarmLockUnlockCluster
02:15:17 

[dani-docker]

The diff LGTM 👍
not sure why the tests are failing but also can't see any relation to the code change

[thaJeztah]

rebased to trigger CI (results were purged)

[thaJeztah]

rebased on top of #313 to fix the build

[thaJeztah]

This is all green now. I'll rebase once more because #313 was merged (to get rid of the extra commit in this PR). We can merge this one, once reviewed by a maintainer

[thaJeztah]

I see that Jenkins in this repository is still using the Ubuntu 16.04 aufs and overlay workers;

• https://jenkins.dockerproject.org/job/Docker-PRs-experimental/configure ubuntu-1604-aufs-stable
• https://jenkins.dockerproject.org/job/Docker-PRs-vendor/configure ubuntu-1604-aufs-stable
• https://jenkins.dockerproject.org/job/Docker-PRs/configure ubuntu-1604-overlay2-stable

Should we change those to 1804-overlay2 ?

oh, hm.. looks like we might not have 18.04; are these auto-scaling? if so should we switch them all to overlay?
https://jenkins.dockerproject.org/computer/

[kolyshkin]

LGTM