[18.09] bump swarmkit to 142a73731c850daf24d32001aa2358b6ffe36eab (bump_v18.09)

[thaJeztah]

full diff: moby/swarmkit@19e791f...142a737

included:

• [18.09 backport] Only update non-terminal tasks on node removal moby/swarmkit#2872 [19.03 backport] Only update non-terminal tasks on node removal
  • backport of Only update non-terminal tasks on node removal. moby/swarmkit#2867 Only update non-terminal tasks on node removal

[thaJeztah]

@dperny @dani-docker @kolyshkin PTAL

[thaJeztah]

Experimental failures (looks like flaky) https://jenkins.dockerproject.org/job/Docker-PRs-experimental/46185/console

01:57:57 PASS: docker_api_swarm_service_test.go:142: DockerSwarmSuite.TestAPISwarmServicesUpdate	31.327s
01:58:43 
01:58:43 ----------------------------------------------------------------------
01:58:43 FAIL: check_test.go:347: DockerSwarmSuite.TearDownTest
01:58:43 
01:58:43 check_test.go:352:
01:58:43     d.Stop(c)
01:58:43 /go/src/github.com/docker/docker/internal/test/daemon/daemon.go:400:
01:58:43     t.Fatalf("Error while stopping the daemon %s : %v", d.id, err)
01:58:43 ... Error: Error while stopping the daemon dc8e10d9d2ee6 : exit status 130
01:58:43 
01:58:43 
01:58:43 ----------------------------------------------------------------------
01:58:43 PANIC: docker_api_swarm_service_test.go:202: DockerSwarmSuite.TestAPISwarmServicesUpdateStartFirst
01:58:43 
01:58:43 [dc8e10d9d2ee6] waiting for daemon to start
01:58:43 [dc8e10d9d2ee6] daemon started
01:58:43 
01:58:43 waited for 1.827144569s (out of 30s)
01:58:43 waited for 319.157121ms (out of 30s)
01:58:43 waited for 830.817µs (out of 30s)
01:58:43 waited for 1.114882079s (out of 30s)
01:58:43 waited for 4.202906325s (out of 30s)
01:58:43 waited for 1.379516ms (out of 30s)
01:58:43 waited for 1.013698223s (out of 30s)
01:58:43 waited for 4.260493944s (out of 30s)
01:58:43 waited for 1.165106ms (out of 30s)
01:58:43 waited for 1.219693218s (out of 30s)
01:58:43 waited for 1.063859208s (out of 30s)
01:58:43 waited for 4.537338355s (out of 30s)
01:58:43 [dc8e10d9d2ee6] daemon stop timeout
01:58:43 Attempt #2: daemon is still running with pid 25965
01:58:43 Attempt #3: daemon is still running with pid 25965
01:58:43 Attempt #4: daemon is still running with pid 25965
01:58:43 [dc8e10d9d2ee6] exiting daemon
01:58:43 ... Panic: Fixture has panicked (see related PANIC)
01:58:43 

[dani-docker]

The diff LGTM 👍
not sure why the tests are failing but also can't see any relation to the code change

[thaJeztah]

rebased to trigger CI (results were purged)

[kolyshkin]

LGTM