This repository was archived by the owner on Oct 13, 2023. It is now read-only.

[19.03 backport] Testing and Jenkinsfile changes [step 2]#383

Merged

andrewhsu merged 65 commits intodocker-archive:19.03from

thaJeztah:19.03_backport_test_fixes_2

Sep 27, 2019

Commits on Sep 26, 2019

pkg/mount: MakeMount: minor optimization

kolyshkin
authored and
thaJeztah
committed
pkg/mount: Mount: minor optimization

kolyshkin
authored and
thaJeztah
committed
daemon/mountVolumes: no need to specify fstype

kolyshkin
authored and
thaJeztah
committed
daemon/mountVolumes(): eliminate MakeRPrivate call

kolyshkin
authored and
thaJeztah
committed
pkg/mount/Make*: optimize

kolyshkin
authored and
thaJeztah
committed
TestContainersAPICreateMountsCreate: minor optimization

kolyshkin
authored and
thaJeztah
committed
integration-cli: fix tests that are silently succeeding when they should not compile

Tibor Vass
authored and
thaJeztah
committed
prepare for rm-gocheck script

Tibor Vass
authored and
thaJeztah
committed
add rm-gocheck.go script and eg templates

Tibor Vass
authored and
thaJeztah
committed
rm-gocheck: normalize c.Check to c.Assert

Tibor Vass
authored and
thaJeztah
committed
rm-gocheck: redress multiline c.Assert calls

Tibor Vass
authored and
thaJeztah
committed
rm-gocheck: c.Assert(...) -> assert.Assert(c, ...)

Tibor Vass
authored and
thaJeztah
committed
rm-gocheck: check.C -> testing.B for BenchmarkXXX

Tibor Vass
authored and
thaJeztah
committed
rm-gocheck: check.C -> testing.T

Tibor Vass
authored and
thaJeztah
committed
rm-gocheck: ErrorMatches -> assert.ErrorContains

Tibor Vass
authored and
thaJeztah
committed
rm-gocheck: normalize to use checker

Tibor Vass
authored and
thaJeztah
committed
rm-gocheck: Not(IsNil) -> != nil

Tibor Vass
authored and
thaJeztah
committed
rm-gocheck: Not(Equals) -> a != b

Tibor Vass
authored and
thaJeztah
committed
rm-gocheck: Not(Matches) -> !cmp.Regexp

Tibor Vass
authored and
thaJeztah
committed
rm-gocheck: Equals -> assert.Equal

Tibor Vass
authored and
thaJeztah
committed
rm-gocheck: DeepEquals -> assert.DeepEqual

Tibor Vass
authored and
thaJeztah
committed
rm-gocheck: HasLen -> assert.Equal + len()

Tibor Vass
authored and
thaJeztah
committed
rm-gocheck: IsNil

Tibor Vass
authored and
thaJeztah
committed
rm-gocheck: NotNil

Tibor Vass
authored and
thaJeztah
committed
rm-gocheck: False

Tibor Vass
authored and
thaJeztah
committed
rm-gocheck: True

Tibor Vass
authored and
thaJeztah
committed
rm-gocheck: redress check.Suite calls

Tibor Vass
authored and
thaJeztah
committed
rm-gocheck: comment out check.Suite calls

Tibor Vass
authored and
thaJeztah
committed
rm-gocheck: comment out check.TestingT

Tibor Vass
authored and
thaJeztah
committed
rm-gocheck: run goimports to compile successfully

Tibor Vass
authored and
thaJeztah
committed
rm-gocheck: Matches -> cmp.Regexp

Tibor Vass
authored and
thaJeztah
committed
rm-gocheck: Not(Contains) -> !strings.Contains

Tibor Vass
authored and
thaJeztah
committed
rm-gocheck: Contains -> strings.Contains

Tibor Vass
authored and
thaJeztah
committed
rm-gocheck: convert check.Commentf to string - with multiple args

Tibor Vass
authored and
thaJeztah
committed
rm-gocheck: convert check.Commentf to string - with just one string

Tibor Vass
authored and
thaJeztah
committed
rm-gocheck: convert check.Commentf to string - other

Tibor Vass
authored and
thaJeztah
committed
rm-gocheck: check.CommentInterface -> string

Tibor Vass
authored and
thaJeztah
committed
rm-gocheck: goimports

Tibor Vass
authored and
thaJeztah
committed
rm-gocheck: fix compile errors from converting check.CommentInterface to string

Tibor Vass
authored and
thaJeztah
committed
fix remaining compile issues

Tibor Vass
authored and
thaJeztah
committed
prepare for eg on waitAndAssert

Tibor Vass
authored and
thaJeztah
committed
waitAndAssert -> poll.WaitOn

Tibor Vass
authored and
thaJeztah
committed
fix remaining issues with checker.Not

Tibor Vass
authored and
thaJeztah
committed
remove waitAndAssert and type casts

Tibor Vass
authored and
thaJeztah
committed
remove rm-gocheck.go and templates

Tibor Vass
authored and
thaJeztah
committed
vendor: remove vdemeester/shakers and go-check/check

Tibor Vass
authored and
thaJeztah
committed
internal/test/suite

Tibor Vass
authored and
thaJeztah
committed
Setup tests

Tibor Vass
authored and
thaJeztah
committed
cleanup

Tibor Vass
authored and
thaJeztah
committed
Update Jenkinsfile

Tibor Vass
authored and
thaJeztah
committed
hack: update scripts

Tibor Vass
authored and
thaJeztah
committed
remove per-test -timeout logic because it does not work

Tibor Vass
authored and
thaJeztah
committed
integration-cli: have helper functions use testing.Helper()

Tibor Vass
authored and
thaJeztah
committed
integration-cli: fix pollCheck

Tibor Vass
authored and
thaJeztah
committed
intgration-cli: fix formatting

Tibor Vass
authored and
thaJeztah
committed
suite: put suite setup inside test run

Tibor Vass
authored and
thaJeztah
committed
integration-cli: remove TestingT

Tibor Vass
authored and
thaJeztah
committed
integration-cli/requirements: Skip windows specific isolation requirements on non-windows

Snorch
authored and
thaJeztah
committed
integration-cli: remove unneeded fmt.Sprintf() in asserts
thaJeztah
committed
hack: have integration-cli use gotestsum codepath

Tibor Vass
authored and
thaJeztah
committed
integration-cli: move each test suite to its own TestX testing function

Tibor Vass
authored and
thaJeztah
committed
hack/test/unit: fix custom TESTFLAGS not working
thaJeztah
committed
Disable TestPsListContainersFilterExited (Windows)

Vikram bir Singh
and
thaJeztah
committed
integration-cli: run goimports

Tibor Vass
authored and
thaJeztah
committed
integration-cli: fix golint issues
thaJeztah
committed