[18.09 backport] Add TC to check dynamic subnet for ingress network#417
[18.09 backport] Add TC to check dynamic subnet for ingress network#417thaJeztah wants to merge 1 commit intodocker-archive:18.09from
Conversation
Signed-off-by: Arko Dasgupta <arko.dasgupta@docker.com> (cherry picked from commit 084f5ab) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
changed the title
kolyshkin
left a comment
kolyshkin
left a comment
There was a problem hiding this comment.
LGTM (assuming that TestServiceWithDefaultAddressPoolInit is not failing)
|
[2019-10-23T17:08:36.806Z] integration/network/service_test.go:369:32:warning: undeclared name: ctx (gosimple) |
| assert.Equal(t, out.IPAM.Config[0].Subnet, "20.20.1.0/24") | ||
|
|
||
| // Also inspect ingress network and make sure its in the same subnet | ||
| out, err = cli.NetworkInspect(ctx, "ingress", types.NetworkInspectOptions{Verbose: true}) |
There was a problem hiding this comment.
[2019-10-23T17:08:36.806Z] integration/network/service_test.go:369:32:warning: undeclared name: ctx (gosimple)
There was a problem hiding this comment.
I guess s/ctx/context.Background()/ or backport moby#38557
There was a problem hiding this comment.
hm.. no, looks like we need moby#39671
.... which is in the other PR 😂
There was a problem hiding this comment.
No, that one is already backported
There was a problem hiding this comment.
hm.. perhaps it was not 🤔
There was a problem hiding this comment.
arf; likely also moby#39332, which is also in the other PR
|
this was included in #401 |
3 participants
backport of the test from moby#39966, because the related swarmkit changes were included in #346