Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

Conversation

@HuKeping
Copy link
Contributor

Redo #411

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Break out OomKillDisable into its own if statement. It shouldn't be bundled with these here (neither should Reservation and Memory for that matter, but that's out of scope :) ).

@HuKeping
Copy link
Contributor Author

why every time i redo the commit it will auto close the PR? Here's my steps:

$ git reset --soft HEAD^
$ edit
$ git commit -a -c ORIG_HEAD
$ git push -f

@LK4D4
Copy link
Contributor

LK4D4 commented Feb 27, 2015

@HuKeping I'm using --amend or rebase -i + --amend if I need to change not last commit. Seems like github have some protection against your case.

@rjnagal
Copy link
Contributor

rjnagal commented Feb 27, 2015

I think your way makes the original commit id go away, which will close the
PR. Doing a rebase -i will preserve the id and github won't bother you.

On Thu, Feb 26, 2015 at 6:16 PM, Alexander Morozov <notifications@github.com

wrote:

@HuKeping https://github.com/HuKeping I'm using --amend or rebase -i +
--amend if I need to change not last commit. Seems like github have some
protection against your case.


Reply to this email directly or view it on GitHub
#412 (comment).

@HuKeping
Copy link
Contributor Author

get it,thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants