Add YOURLS container documentation #1078
Conversation
tianon
left a comment
tianon
left a comment
There was a problem hiding this comment.
Just a couple very minor comments, otherwise looks fine. 👍
yourls/content.md
Outdated
|
|
||
| ```console | ||
| $ docker run --name some-%%REPO%% --link some-mysql:mysql -d %%IMAGE%% \ | ||
| -e YOURLS_SITE="https://example.com" |
There was a problem hiding this comment.
This -e needs to be before %%IMAGE%% to work, doesn't it?
yourls/content.md
Outdated
|
|
||
| ```console | ||
| $ docker run --name some-%%REPO%%s -e YOURLS_DB_HOST=10.1.2.3:3306 \ | ||
| -e YOURLS_DB_USER=... -e YOURLS_DB_PASS=... -d %%REPO%% |
There was a problem hiding this comment.
%%REPO%% here at the end should be %%IMAGE%% instead (so the multi-arch descriptions have the right ARCH/yourls image name here)
There was a problem hiding this comment.
You seem right. I took WordPress template as example: https://github.com/docker-library/docs/blob/8117c12eda4829c1c57eb07c02a62028d1e2bfe8/wordpress/content.md
|
(If you don't get to those before @yosifkit reviews docker-library/official-images#3752, we'll likely just take care of them directly to get this merged today.) |
|
@tianon Thanks for the review, I updated to reflect your comments. |
3 participants
Proposing YOURLS (https://github.com/YOURLS/YOURLS) for creating a new official image.