Fixed instructions in Redis container docs#1486
Fixed instructions in Redis container docs#1486sbkok wants to merge 1 commit intodocker-library:masterfrom
Conversation
… from a redis-cli container
|
|
||
| ```console | ||
| $ docker run --name some-redis -p 127.0.0.1:6379:6379 -d %%IMAGE%% | ||
| ``` |
There was a problem hiding this comment.
I'd rather not suggest this to users, since this is really something that should be easily inferred by someone familiar with Docker and/or how -p works (and we'd prefer to keep the documentation somewhat succinct and specific to Redis instead of a general guide to using Docker).
| ```console | ||
| $ docker run -it --network some-network --rm %%IMAGE%% redis-cli -h some-redis | ||
| $ docker network create some-network | ||
| ``` |
There was a problem hiding this comment.
Along similar lines, the docker network create bits were intentionally left out of #1441 (as implied by the title) -- we'd prefer not to document Docker basics here and instead provide more reference/tips for using Redis with this image.
|
Thanks for the review @tianon. I agree that we should not completely duplicate the instructions as provided by the docker docs, however, at the moment the instructions in the doc make it look like it should have worked if you first run the server followed by running the redis cli. In my opinion, we should at least point the user in the right direction by referencing the docs on how to set it up if you don’t want to include step-by-step instructions. What do you think about this? |
2 participants
Updated docs as the current instructions are not working.
Added instructions to:
redis-clito a redis server when both run in docker using docker networks.