docker: add a note about TLS#1525
Merged
tianon merged 1 commit intodocker-library:masterfrom Jul 17, 2019
Merged
Conversation
Contributor
Author
|
I think we should remove this default from the |
Member
|
@justincormack if we remove the default, the container will default to unix-socket only, which makes for a pretty irritating user experience from a container 😞 Any ideas for how to resolve that? |
Contributor
Author
My suggestion is to let dind create TLS files on start up $ docker run -d --privileged --name some-docker \
-e DIND_TLS_SAN=DNS:docker,DNS:localhost docker:dind
$ docker cp some-docker:/certs/for-client ./certs-for-client
$ docker run --rm --link some-docker:docker -v $(pwd)/certs-for-client:/root/.docker \
-e DOCKER_HOST=tcp://docker:2376 docker info |
Contributor
Author
|
Can we get this merged? |
tianon
reviewed
Jul 16, 2019
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
tianon
approved these changes
Jul 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TCP connection without TLS is completely insecure and can easily result
in container breakout.
Signed-off-by: Akihiro Suda akihiro.suda.cz@hco.ntt.co.jp