Skip to content

Add official Friendica docs#1551

Merged
tianon merged 2 commits intodocker-library:masterfrom
nupplaphil:friendica
Jan 8, 2020
Merged

Add official Friendica docs#1551
tianon merged 2 commits intodocker-library:masterfrom
nupplaphil:friendica

Conversation

@nupplaphil
Copy link
Copy Markdown
Contributor

@nupplaphil nupplaphil commented Aug 10, 2019

@nupplaphil nupplaphil changed the title Add official Friendica image Add official Friendica docs Aug 10, 2019
Copy link
Copy Markdown
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this seems OK, just a few minor adjustments I'd suggest.

It might also be worthwhile to trim this down (like only providing one example stack.yml instead of two explicit and one implied) and providing the additional examples/details over in the GitHub repo which this can then link to ("find more examples for different scenarios over at XYZ").

Comment thread friendica/content.md Outdated
Comment thread friendica/content.md Outdated
Comment thread friendica/content.md Outdated
Comment thread friendica/content.md Outdated
Comment thread friendica/content.md Outdated
Comment thread friendica/content.md Outdated
Comment thread friendica/content.md Outdated
Comment thread friendica/content.md Outdated
Comment thread friendica/content.md Outdated
Copy link
Copy Markdown
Member

@yosifkit yosifkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments, suggestions, and questions.

Comment thread friendica/content.md

There are three options to enable the cron-job for Friendica:

- Using the default Image and activate the cron-job (see [Installation](https://friendi.ca/resources/installation/), sector `Activating scheduled tasks`)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to imply that users exec into their running friendica container and php bin/daemon.php start to start cron? That is not a great solution since a container restart will stop the cron task.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently there is no other option if you don't want to start an own cron-container. I can add an attention text to this option that you have to restart the cron manually each container restart (which is indeed not a very good solution ..)

I created a feature request for a better solution: friendica/friendica#8043

Comment thread friendica/content.md Outdated
Comment thread friendica/content.md Outdated
Comment thread friendica/content.md Outdated
@tianon tianon merged commit d5786a7 into docker-library:master Jan 8, 2020
@nupplaphil nupplaphil deleted the friendica branch January 8, 2020 22:24
@tianon tianon mentioned this pull request Jan 9, 2020
Comment thread friendica/logo.svg
inkscape:label="Effects"
style="display:inline">
<rect
style="fill:url(#linearGradient3930);fill-opacity:1;stroke:none"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, this linearGradient3930 is not defined elsewhere, which makes ImageMagick choke on this file:

convert-im6.q16: unrecognized color `linearGradient3930' @ warning/color.c/GetColorCompliance/1052.
convert-im6.q16: non-conforming drawing primitive definition `fill' @ error/draw.c/RenderMVGContent/4301.
convert-im6.q16: unrecognized color `linearGradient3930' @ warning/color.c/GetColorCompliance/1052.
convert-im6.q16: non-conforming drawing primitive definition `fill' @ error/draw.c/RenderMVGContent/4301.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants