Skip to content

Mariadb update#1889

Merged
yosifkit merged 5 commits intodocker-library:masterfrom
grooverdan:mariadb_update
May 13, 2021
Merged

Mariadb update#1889
yosifkit merged 5 commits intodocker-library:masterfrom
grooverdan:mariadb_update

Conversation

@grooverdan
Copy link
Copy Markdown
Contributor

@grooverdan grooverdan commented Mar 12, 2021

Bulk update largely to cover the new names being available and a few other cleanups.

tianon
tianon reviewed Mar 12, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, minus one minor bit that seems like a typo/oversight 😄

Comment thread mariadb/content.md Outdated
@yosifkit yosifkit mentioned this pull request Mar 22, 2021
Closed
yosifkit
yosifkit approved these changes Mar 22, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@yosifkit yosifkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting on an update to the images that contains this functionality so that the documentation stays in sync.

@grooverdan
Copy link
Copy Markdown
Contributor Author

grooverdan commented Mar 23, 2021

Sure. I'm happy to see #1898 land and I'll rebase this before next expected release 2021-04-30

grooverdan and others added 5 commits May 3, 2021 08:59
@grooverdan
mariadb: add MARIADB_* environment variables from docker-library#333
db5beb4
@grooverdan
mariadb: network naming from docker-library#1860
c6e1827
@grooverdan
mariadb: doc contents
6ce9370 
Place manditory environment variables first.

Add missing MARIADB_ROOT_HOST.

Document .sql.xz files for initialization.

Note .sh files without execute permission are sourced.
@grooverdan
mariadb: issues - JIRA Docker component
58a3136
@dbart @grooverdan
Various README edits to improve readability
8f6dd3f
@grooverdan grooverdan mentioned this pull request May 2, 2021
Merged
@yosifkit
Copy link
Copy Markdown
Member

yosifkit commented May 3, 2021

I see more commits here; now that an image is up with MARIADB_* variables, (docker-library/official-images#10070), are these docs ready?

@grooverdan
Copy link
Copy Markdown
Contributor Author

grooverdan commented May 3, 2021

I see more commits here; now that an image is up with MARIADB_* variables, (docker-library/official-images#10070), are these docs ready?

The one that is up is the Alpha release. The rest are coming I expect within a week. Can we merge this when the next stable releases get updated please.

@grooverdan grooverdan mentioned this pull request May 12, 2021
Merged
@yosifkit yosifkit merged commit a422863 into docker-library:master May 13, 2021
@grooverdan
Copy link
Copy Markdown
Contributor Author

grooverdan commented May 13, 2021

Thank you.

@grooverdan grooverdan deleted the mariadb_update branch May 13, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianon tianon tianon left review comments

@yosifkit yosifkit yosifkit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@grooverdan @yosifkit @tianon @dbart