Move to Debian 12 (bookworm)#235
Move to Debian 12 (bookworm)#235tianon merged 1 commit intodocker-library:masterfrom bilhackmac:master
Conversation
2.4/Dockerfile
Outdated
| | awk '/=>/ { print $(NF-1) }' \ | ||
| | sort -u \ | ||
| | xargs -r basename -a \ |
There was a problem hiding this comment.
Similar comment to docker-library/python#822 (comment):
| | awk '/=>/ { print $(NF-1) }' \ | |
| | sort -u \ | |
| | xargs -r basename -a \ | |
| | awk '/=>/ { so = $(NF-1); if (index(so, "/usr/local/") == 1) { next }; gsub("^/(usr/)?", "", so); print so }' \ | |
| | sort -u \ |
(I'm happy to take over from here if you'd prefer 👍)
There was a problem hiding this comment.
Comment is not available anymore.
I'll try to understand why you wan't to skip shared objects inside /usr/local.
Otherwise rely on base name instead of an absolute path transformed in relative path may be more robust in time. What do you think ?
There was a problem hiding this comment.
Doh, sorry - GitHub did us dirty. I've updated the link above to docker-library/python#822 (comment), which might answer your question.
The reason I'd prefer not to rely on basename here and instead be as specific as we can reasonably be while still being generic enough to match both /usr/something and /something is that something like foo.so might match inside other things like man pages, other directories, etc, and the purpose of this code is to only match things installed by packages, and to do so reliably so we can keep the proper library dependencies installed (and only the necessary dependencies), which is also why we should skip any matches in /usr/local (which I don't think we have any of right now, and they'll generally just return nothing in dpkg-query --search, but we might as well exclude them explicitly just to be sure and to put less work on dpkg-query --search).
There was a problem hiding this comment.
Ok I update commit in this way
|
Thank you! 👍 |
Changes: - docker-library/httpd@242f3c6: Merge pull request docker-library/httpd#235 from bilhackmac/master - docker-library/httpd@c75f0f7: Move to Debian 12 (bookworm) - docker-library/httpd@84fab6b: Merge pull request docker-library/httpd#236 from infosiftr/bookworm - docker-library/httpd@c87146e: Update to Debian bookworm
2 participants
No description provided.