Add "file_env" support, especially for Docker secrets#237
Conversation
|
I saw this was added to (That being said, we defer to you, @ltangvald -- however you think this should be implemented here is the direction we'll go. 👍) |
|
cc @cyli @mstanleyjones FYI |
|
Hm, yeah. I'm not 100% sure why we used the same variable (other than a general desire to keep the number of extra env variables down). We considered the chance of accidentally setting the password to a valid file path low, but I agree it's cleaner to make it explicit. |
This adds explicit support for the following: - `MYSQL_ROOT_PASSWORD_FILE` - `MYSQL_DATABASE_FILE` - `MYSQL_USER_FILE` - `MYSQL_PASSWORD_FILE`
|
Yeah, the goal of the function was to abstract the behavior in a clean, generic way so we don't have "this or that" logic peppered all over the file (which is error prone on top of verbose). 😅 I've updated to push this change to all the versions now. 😄 👍 |
- `elasticsearch`: 1.7.6, 2.4.2 - `mongo`: 3.4.0-rc5 - `mysql`: add `file_env` support (docker-library/mysql#237) - `percona`: 5.5.53-rel38.5-1.jessie - `postgres`: add `tzdata` to alpine variant (docker-library/postgres#226), add `file_env` support (docker-library/postgres#225) - `python`: 3.6.0b4 - `rabbitmq`: 3.6.6 - `redmine`: add `file_env` support (docker-library/redmine#43) - `rocket.chat`: 0.46.0
Adds a section in the docs for the new capabilities added by docker-library/mysql#237.
…he root password (see docker-library/mysql#237). If the variable exists, cat the contents into the MYSQL_ROOT_PASSWORD field before running the mysqldump command.
This adds explicit support for the following:
MYSQL_ROOT_PASSWORD_FILEMYSQL_DATABASE_FILEMYSQL_USER_FILEMYSQL_PASSWORD_FILESee also:
I've only updated
8.0/docker-entrypoint.shhere so that this can serve as a straw-man for discussion -- once the discussion concludes, I'll update the PR with the result and push the functionality across the board to all supported versions. 👍