Add nodejs v11, update v10, remove unsupported architectures & variations #4986

PeterDaveHello · 2018-10-24T11:16:26Z

v11:

v10:

Jessie removal:

Remove "jessie" from unsupported architectures nodejs/docker-node#863

i386 removal:

Remove i386 support from binary-release-based 10 variants nodejs/docker-node#823

yosifkit · 2018-10-24T23:04:01Z

Diff:

diff --git a/_bashbrew-arches b/_bashbrew-arches
index 7408f23..a899c56 100644
--- a/_bashbrew-arches
+++ b/_bashbrew-arches
@@ -1,3 +1,27 @@
+node:11.0 @ amd64
+node:11.0 @ arm32v7
+node:11.0 @ arm64v8
+node:11.0 @ i386
+node:11.0 @ ppc64le
+node:11.0 @ s390x
+node:11.0-alpine @ amd64
+node:11.0-alpine @ arm32v6
+node:11.0-alpine @ arm64v8
+node:11.0-alpine @ i386
+node:11.0-alpine @ ppc64le
+node:11.0-alpine @ s390x
+node:11.0-slim @ amd64
+node:11.0-slim @ arm32v7
+node:11.0-slim @ arm64v8
+node:11.0-slim @ i386
+node:11.0-slim @ ppc64le
+node:11.0-slim @ s390x
+node:11.0-stretch @ amd64
+node:11.0-stretch @ arm32v7
+node:11.0-stretch @ arm64v8
+node:11.0-stretch @ i386
+node:11.0-stretch @ ppc64le
+node:11.0-stretch @ s390x
 node:alpine @ amd64
 node:alpine @ arm32v6
 node:alpine @ arm64v8
diff --git a/_bashbrew-list b/_bashbrew-list
index 62169ab..888706b 100644
--- a/_bashbrew-list
+++ b/_bashbrew-list
@@ -49,6 +49,16 @@ node:10.12.0-alpine
 node:10.12.0-jessie
 node:10.12.0-slim
 node:10.12.0-stretch
+node:11.0
+node:11.0-alpine
+node:11.0-jessie
+node:11.0-slim
+node:11.0-stretch
+node:11.0.0
+node:11.0.0-alpine
+node:11.0.0-jessie
+node:11.0.0-slim
+node:11.0.0-stretch
 node:alpine
 node:boron
 node:boron-alpine
diff --git a/node_alpine/Dockerfile b/node_11.0-alpine/Dockerfile
similarity index 99%
copy from node_alpine/Dockerfile
copy to node_11.0-alpine/Dockerfile
index 90c9bbf..e8ad546 100644
--- a/node_alpine/Dockerfile
+++ b/node_11.0-alpine/Dockerfile
@@ -1,6 +1,6 @@
 FROM alpine:3.8
 
-ENV NODE_VERSION 10.12.0
+ENV NODE_VERSION 11.0.0
 
 RUN addgroup -g 1000 node \
     && adduser -u 1000 -G node -s /bin/sh -D node \
diff --git a/node_slim/Dockerfile b/node_11.0-slim/Dockerfile
similarity index 99%
copy from node_slim/Dockerfile
copy to node_11.0-slim/Dockerfile
index c4d00c7..c7001b7 100644
--- a/node_slim/Dockerfile
+++ b/node_11.0-slim/Dockerfile
@@ -21,7 +21,7 @@ RUN set -ex \
     gpg --keyserver hkp://pgp.mit.edu:80 --recv-keys "$key" ; \
   done
 
-ENV NODE_VERSION 10.12.0
+ENV NODE_VERSION 11.0.0
 
 RUN buildDeps='xz-utils' \
     && ARCH= && dpkgArch="$(dpkg --print-architecture)" \
diff --git a/node_stretch/Dockerfile b/node_11.0-stretch/Dockerfile
similarity index 99%
copy from node_stretch/Dockerfile
copy to node_11.0-stretch/Dockerfile
index 1ab32fc..3ad8c2c 100644
--- a/node_stretch/Dockerfile
+++ b/node_11.0-stretch/Dockerfile
@@ -21,7 +21,7 @@ RUN set -ex \
     gpg --keyserver hkp://pgp.mit.edu:80 --recv-keys "$key" ; \
   done
 
-ENV NODE_VERSION 10.12.0
+ENV NODE_VERSION 11.0.0
 
 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \
   && case "${dpkgArch##*-}" in \
diff --git a/node_latest/Dockerfile b/node_11.0/Dockerfile
similarity index 99%
copy from node_latest/Dockerfile
copy to node_11.0/Dockerfile
index c5563f8..475cc55 100644
--- a/node_latest/Dockerfile
+++ b/node_11.0/Dockerfile
@@ -21,7 +21,7 @@ RUN set -ex \
     gpg --keyserver hkp://pgp.mit.edu:80 --recv-keys "$key" ; \
   done
 
-ENV NODE_VERSION 10.12.0
+ENV NODE_VERSION 11.0.0
 
 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \
   && case "${dpkgArch##*-}" in \

yosifkit · 2018-10-25T19:50:13Z

node:11.0 ie jessie arches are still wrong: nodejs/docker-node#863, nodejs/docker-node#823

PeterDaveHello · 2018-10-26T04:08:48Z

@yosifkit does that mean we should merge nodejs/docker-node#863 nodejs/docker-node#823 first?

holm · 2018-10-26T14:33:05Z

Would be good to get this up on the Docker Hub, as we would like to start testing against it. The PRs linked doesn't seem like they should be blocking this?

yosifkit · 2018-10-26T20:57:41Z

We don't want to advertise versions that will constantly fail to be built, especially on a new major release. The linked issues have been open for months, but you could just adjust the library/node file in this PR to have the correct arches for the new version and then deal with the other PRs separately.

PeterDaveHello · 2018-10-27T11:58:49Z

@yosifkit would the best way to get this approved is to manually remove the variations that should be removed? Thanks.

tianon · 2018-10-29T18:22:52Z

That would certainly help, yes. Those two really need to be resolved -- I'm not sure what the Node.js image maintainers are waiting for, as those builds cannot possibly succeed (and have been failing for ages now), so it's dishonest at best for this file to advertise "support" for those architecture combinations.

tianon · 2018-10-29T22:22:59Z

library/node

+Tags: 11.0.0-jessie, 11.0-jessie, 11.0.0, 11.0
+Architectures: arm32v7, arm64v8, amd64, i386, ppc64le, s390x
+GitCommit: e007863a848ca34221bb24549293567e2336445b
+Directory: 11/jessie


To be totally frank, why add 11-jessie at all? Why not simply let Debian Jessie support die with Node.js 11?

IMO, 11.0, etc should point to stretch instead, especially since this is a brand new release (previously unsupported completely).

Shouldn't this also have at least 11 as an additional alias?

@tianon maybe need your feedback here: nodejs/docker-node#863, thanks.

I think the feedback I provided in my original post there was pretty comprehensive -- the bottom line is that the way the Node.js Docker repo is tracking "supported" architectures is extremely error-prone without any good reason that I can see.

To @chorrell's specific follow-up question there (which from what I can tell shouldn't have been blocking the merge), IMO, y'all should've switched node:*-slim over to stretch ages ago, but yes, you'll need to update the architectures files again in the opposite direction if you update slim to stretch.

PeterDaveHello · 2018-10-30T16:51:47Z

Updated, thanks.

tianon · 2018-10-30T23:16:33Z

There's still a set of issues. Here's the changes I see that need to happen here:

11 and latest aliases on the new 11.x versions
11 should be stretch-default and stretch-only (there's no reason to introduce new jessie variants for 11); including 11-slim
jessie variants all need fixed architectures (which can be a separate PR for 6, 8, and 10)

PeterDaveHello · 2018-10-31T09:49:25Z

Waiting for the latest PR to be reviewed and merged in docker-node repository, and then we will update this PR.

schmod · 2018-10-31T13:35:35Z

Do we also need a 10.13 tag?

arnulfojr · 2018-10-31T17:12:16Z

Could you please include the 10.13 tag and the dubnium LTS tag as well? 🙏

chorrell · 2018-10-31T17:24:08Z

10.3 would be a separate PR.

PeterDaveHello · 2018-10-31T18:31:57Z

We're still working on it, I may put v10 update here in the same PR, but please wait for a while more, will put updates ASAP here soon.

PeterDaveHello · 2018-11-01T05:38:39Z

@tianon as we want to migrate v8 & v10 to Stretch later(compare to v11, as they are LTS release), do you have any suggestion how can we pass the CI? Thanks.

PeterDaveHello · 2018-11-01T17:59:55Z

We're trying to remove those unsupported architectures from the architectures files temporarily before the migration from jessie to stretch, will update this PR soon.

- nodejs/docker-node#881 - https://github.com/nodejs/node/releases/tag/v11.0.0 - https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V11.md

PeterDaveHello · 2018-11-01T20:00:24Z

Should be good now...

tianon · 2018-11-01T20:08:54Z

Diff:

diff --git a/_bashbrew-arches b/_bashbrew-arches
index 7408f23..8be7f5d 100644
--- a/_bashbrew-arches
+++ b/_bashbrew-arches
@@ -6,23 +6,14 @@ node:alpine @ ppc64le
 node:alpine @ s390x
 node:boron @ amd64
 node:boron @ arm32v7
-node:boron @ arm64v8
 node:boron @ i386
-node:boron @ ppc64le
-node:boron @ s390x
 node:boron-alpine @ amd64
 node:boron-onbuild @ amd64
 node:boron-onbuild @ arm32v7
-node:boron-onbuild @ arm64v8
 node:boron-onbuild @ i386
-node:boron-onbuild @ ppc64le
-node:boron-onbuild @ s390x
 node:boron-slim @ amd64
 node:boron-slim @ arm32v7
-node:boron-slim @ arm64v8
 node:boron-slim @ i386
-node:boron-slim @ ppc64le
-node:boron-slim @ s390x
 node:boron-stretch @ amd64
 node:boron-stretch @ arm32v7
 node:boron-stretch @ arm64v8
@@ -31,10 +22,7 @@ node:boron-stretch @ ppc64le
 node:boron-stretch @ s390x
 node:carbon @ amd64
 node:carbon @ arm32v7
-node:carbon @ arm64v8
 node:carbon @ i386
-node:carbon @ ppc64le
-node:carbon @ s390x
 node:carbon-alpine @ amd64
 node:carbon-alpine @ arm32v6
 node:carbon-alpine @ arm64v8
@@ -43,16 +31,10 @@ node:carbon-alpine @ ppc64le
 node:carbon-alpine @ s390x
 node:carbon-onbuild @ amd64
 node:carbon-onbuild @ arm32v7
-node:carbon-onbuild @ arm64v8
 node:carbon-onbuild @ i386
-node:carbon-onbuild @ ppc64le
-node:carbon-onbuild @ s390x
 node:carbon-slim @ amd64
 node:carbon-slim @ arm32v7
-node:carbon-slim @ arm64v8
 node:carbon-slim @ i386
-node:carbon-slim @ ppc64le
-node:carbon-slim @ s390x
 node:carbon-stretch @ amd64
 node:carbon-stretch @ arm32v7
 node:carbon-stretch @ arm64v8
@@ -61,21 +43,28 @@ node:carbon-stretch @ ppc64le
 node:carbon-stretch @ s390x
 node:chakracore @ amd64
 node:chakracore-8 @ amd64
+node:dubnium @ amd64
+node:dubnium @ arm32v7
+node:dubnium-alpine @ amd64
+node:dubnium-alpine @ arm32v6
+node:dubnium-alpine @ arm64v8
+node:dubnium-alpine @ i386
+node:dubnium-alpine @ ppc64le
+node:dubnium-alpine @ s390x
+node:dubnium-slim @ amd64
+node:dubnium-slim @ arm32v7
+node:dubnium-stretch @ amd64
+node:dubnium-stretch @ arm32v7
+node:dubnium-stretch @ arm64v8
+node:dubnium-stretch @ ppc64le
+node:dubnium-stretch @ s390x
 node:latest @ amd64
 node:latest @ arm32v7
 node:latest @ arm64v8
-node:latest @ i386
 node:latest @ ppc64le
 node:latest @ s390x
 node:slim @ amd64
 node:slim @ arm32v7
 node:slim @ arm64v8
-node:slim @ i386
 node:slim @ ppc64le
 node:slim @ s390x
-node:stretch @ amd64
-node:stretch @ arm32v7
-node:stretch @ arm64v8
-node:stretch @ i386
-node:stretch @ ppc64le
-node:stretch @ s390x
diff --git a/_bashbrew-list b/_bashbrew-list
index 62169ab..990226d 100644
--- a/_bashbrew-list
+++ b/_bashbrew-list
@@ -39,16 +39,28 @@ node:10-alpine
 node:10-jessie
 node:10-slim
 node:10-stretch
-node:10.12
-node:10.12-alpine
-node:10.12-jessie
-node:10.12-slim
-node:10.12-stretch
-node:10.12.0
-node:10.12.0-alpine
-node:10.12.0-jessie
-node:10.12.0-slim
-node:10.12.0-stretch
+node:10.13
+node:10.13-alpine
+node:10.13-jessie
+node:10.13-slim
+node:10.13-stretch
+node:10.13.0
+node:10.13.0-alpine
+node:10.13.0-jessie
+node:10.13.0-slim
+node:10.13.0-stretch
+node:11
+node:11-alpine
+node:11-slim
+node:11-stretch
+node:11.0
+node:11.0-alpine
+node:11.0-slim
+node:11.0-stretch
+node:11.0.0
+node:11.0.0-alpine
+node:11.0.0-slim
+node:11.0.0-stretch
 node:alpine
 node:boron
 node:boron-alpine
@@ -69,7 +81,11 @@ node:chakracore-8.11.1
 node:chakracore-10
 node:chakracore-10.6
 node:chakracore-10.6.0
-node:jessie
+node:dubnium
+node:dubnium-alpine
+node:dubnium-jessie
+node:dubnium-slim
+node:dubnium-stretch
 node:latest
 node:slim
 node:stretch
diff --git a/node_alpine/Dockerfile b/node_alpine/Dockerfile
index 90c9bbf..e8ad546 100644
--- a/node_alpine/Dockerfile
+++ b/node_alpine/Dockerfile
@@ -1,6 +1,6 @@
 FROM alpine:3.8
 
-ENV NODE_VERSION 10.12.0
+ENV NODE_VERSION 11.0.0
 
 RUN addgroup -g 1000 node \
     && adduser -u 1000 -G node -s /bin/sh -D node \
diff --git a/node_alpine/Dockerfile b/node_dubnium-alpine/Dockerfile
similarity index 99%
copy from node_alpine/Dockerfile
copy to node_dubnium-alpine/Dockerfile
index 90c9bbf..f5c22ab 100644
--- a/node_alpine/Dockerfile
+++ b/node_dubnium-alpine/Dockerfile
@@ -1,6 +1,6 @@
 FROM alpine:3.8
 
-ENV NODE_VERSION 10.12.0
+ENV NODE_VERSION 10.13.0
 
 RUN addgroup -g 1000 node \
     && adduser -u 1000 -G node -s /bin/sh -D node \
diff --git a/node_slim/Dockerfile b/node_dubnium-slim/Dockerfile
similarity index 99%
copy from node_slim/Dockerfile
copy to node_dubnium-slim/Dockerfile
index c4d00c7..20c9cb8 100644
--- a/node_slim/Dockerfile
+++ b/node_dubnium-slim/Dockerfile
@@ -21,7 +21,7 @@ RUN set -ex \
     gpg --keyserver hkp://pgp.mit.edu:80 --recv-keys "$key" ; \
   done
 
-ENV NODE_VERSION 10.12.0
+ENV NODE_VERSION 10.13.0
 
 RUN buildDeps='xz-utils' \
     && ARCH= && dpkgArch="$(dpkg --print-architecture)" \
diff --git a/node_stretch/Dockerfile b/node_dubnium-stretch/Dockerfile
similarity index 99%
rename from node_stretch/Dockerfile
rename to node_dubnium-stretch/Dockerfile
index 1ab32fc..c9ad9bb 100644
--- a/node_stretch/Dockerfile
+++ b/node_dubnium-stretch/Dockerfile
@@ -21,7 +21,7 @@ RUN set -ex \
     gpg --keyserver hkp://pgp.mit.edu:80 --recv-keys "$key" ; \
   done
 
-ENV NODE_VERSION 10.12.0
+ENV NODE_VERSION 10.13.0
 
 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \
   && case "${dpkgArch##*-}" in \
diff --git a/node_latest/Dockerfile b/node_dubnium/Dockerfile
similarity index 99%
copy from node_latest/Dockerfile
copy to node_dubnium/Dockerfile
index c5563f8..100af7a 100644
--- a/node_latest/Dockerfile
+++ b/node_dubnium/Dockerfile
@@ -21,7 +21,7 @@ RUN set -ex \
     gpg --keyserver hkp://pgp.mit.edu:80 --recv-keys "$key" ; \
   done
 
-ENV NODE_VERSION 10.12.0
+ENV NODE_VERSION 10.13.0
 
 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \
   && case "${dpkgArch##*-}" in \
diff --git a/node_latest/Dockerfile b/node_latest/Dockerfile
index c5563f8..3ad8c2c 100644
--- a/node_latest/Dockerfile
+++ b/node_latest/Dockerfile
@@ -1,4 +1,4 @@
-FROM buildpack-deps:jessie
+FROM buildpack-deps:stretch
 
 RUN groupadd --gid 1000 node \
   && useradd --uid 1000 --gid node --shell /bin/bash --create-home node
@@ -21,7 +21,7 @@ RUN set -ex \
     gpg --keyserver hkp://pgp.mit.edu:80 --recv-keys "$key" ; \
   done
 
-ENV NODE_VERSION 10.12.0
+ENV NODE_VERSION 11.0.0
 
 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \
   && case "${dpkgArch##*-}" in \
diff --git a/node_slim/Dockerfile b/node_slim/Dockerfile
index c4d00c7..37ff88f 100644
--- a/node_slim/Dockerfile
+++ b/node_slim/Dockerfile
@@ -1,10 +1,24 @@
-FROM debian:jessie-slim
+FROM debian:stretch-slim
 
 RUN groupadd --gid 1000 node \
   && useradd --uid 1000 --gid node --shell /bin/bash --create-home node
 
-# gpg keys listed at https://github.com/nodejs/node#release-team
-RUN set -ex \
+ENV NODE_VERSION 11.0.0
+
+RUN buildDeps='xz-utils' \
+    && ARCH= && dpkgArch="$(dpkg --print-architecture)" \
+    && case "${dpkgArch##*-}" in \
+      amd64) ARCH='x64';; \
+      ppc64el) ARCH='ppc64le';; \
+      s390x) ARCH='s390x';; \
+      arm64) ARCH='arm64';; \
+      armhf) ARCH='armv7l';; \
+      i386) ARCH='x86';; \
+      *) echo "unsupported architecture"; exit 1 ;; \
+    esac \
+    && set -ex \
+    && apt-get update && apt-get install -y ca-certificates curl wget gnupg dirmngr $buildDeps --no-install-recommends \
+    && rm -rf /var/lib/apt/lists/* \
     && for key in \
       94AE36675C464D64BAFA68DD7434390BDBE9B9C5 \
       FD3A5288F042B6850C66B31F09FE44734EB7990E \
@@ -19,24 +33,7 @@ RUN set -ex \
       gpg --keyserver hkp://p80.pool.sks-keyservers.net:80 --recv-keys "$key" || \
       gpg --keyserver hkp://ipv4.pool.sks-keyservers.net --recv-keys "$key" || \
       gpg --keyserver hkp://pgp.mit.edu:80 --recv-keys "$key" ; \
-  done
-
-ENV NODE_VERSION 10.12.0
-
-RUN buildDeps='xz-utils' \
-    && ARCH= && dpkgArch="$(dpkg --print-architecture)" \
-    && case "${dpkgArch##*-}" in \
-      amd64) ARCH='x64';; \
-      ppc64el) ARCH='ppc64le';; \
-      s390x) ARCH='s390x';; \
-      arm64) ARCH='arm64';; \
-      armhf) ARCH='armv7l';; \
-      i386) ARCH='x86';; \
-      *) echo "unsupported architecture"; exit 1 ;; \
-    esac \
-    && set -x \
-    && apt-get update && apt-get install -y ca-certificates curl wget $buildDeps --no-install-recommends \
-    && rm -rf /var/lib/apt/lists/* \
+    done \
     && curl -fsSLO --compressed "https://nodejs.org/dist/v$NODE_VERSION/node-v$NODE_VERSION-linux-$ARCH.tar.xz" \
     && curl -fsSLO --compressed "https://nodejs.org/dist/v$NODE_VERSION/SHASUMS256.txt.asc" \
     && gpg --batch --decrypt --output SHASUMS256.txt SHASUMS256.txt.asc \

tianon · 2018-11-01T21:12:24Z

LGTM

Build test of #4986; fe942eb; amd64 (node):

$ bashbrew build node:8.12.0-jessie
Using bashbrew/cache:a00a63e77ed3afe46e18c63a4029e5d466c2d65e4e37815db493e5bffae852cb (node:8.12.0-jessie)
Tagging node:8.12.0-jessie
Tagging node:8.12-jessie
Tagging node:8-jessie
Tagging node:carbon-jessie
Tagging node:8.12.0
Tagging node:8.12
Tagging node:8
Tagging node:carbon

$ test/run.sh node:8.12.0-jessie
testing node:8.12.0-jessie
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:8.12.0-alpine
Using bashbrew/cache:1f3bbf8a0d21caed65fd15b95ba3f2b14621ce32a280d8abbe7b4eccc0dffa39 (node:8.12.0-alpine)
Tagging node:8.12.0-alpine
Tagging node:8.12-alpine
Tagging node:8-alpine
Tagging node:carbon-alpine

$ test/run.sh node:8.12.0-alpine
testing node:8.12.0-alpine
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:8.12.0-onbuild
Using bashbrew/cache:df36cb44e979aee0ed6b8f0247a5b1e810da360a7c7a9d259455c521b05f20e6 (node:8.12.0-onbuild)
Tagging node:8.12.0-onbuild
Tagging node:8.12-onbuild
Tagging node:8-onbuild
Tagging node:carbon-onbuild

$ test/run.sh node:8.12.0-onbuild
testing node:8.12.0-onbuild
	'override-cmd' [1/1]...passed


$ bashbrew build node:8.12.0-slim
Using bashbrew/cache:7e872fa8af22d8496769e621101684220911e28043565fe489ac8aca69ce6fb9 (node:8.12.0-slim)
Tagging node:8.12.0-slim
Tagging node:8.12-slim
Tagging node:8-slim
Tagging node:carbon-slim

$ test/run.sh node:8.12.0-slim
testing node:8.12.0-slim
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:8.12.0-stretch
Using bashbrew/cache:4c10a05cf15858426fc0c163b6fa61eb0022606977ad0cfe12c655f7b078f32d (node:8.12.0-stretch)
Tagging node:8.12.0-stretch
Tagging node:8.12-stretch
Tagging node:8-stretch
Tagging node:carbon-stretch

$ test/run.sh node:8.12.0-stretch
testing node:8.12.0-stretch
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:6.14.4-jessie
Using bashbrew/cache:3a5432381a0f1fe82385eca7e6072b1af4409af6f6b90c3bd2763f29d067227e (node:6.14.4-jessie)
Tagging node:6.14.4-jessie
Tagging node:6.14-jessie
Tagging node:6-jessie
Tagging node:boron-jessie
Tagging node:6.14.4
Tagging node:6.14
Tagging node:6
Tagging node:boron

$ test/run.sh node:6.14.4-jessie
testing node:6.14.4-jessie
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:6.14.4-alpine
Using bashbrew/cache:e1f6349e7dde65e5ea1fed65dc2c37c2d63d45cd71883006bdc16638bbb85253 (node:6.14.4-alpine)
Tagging node:6.14.4-alpine
Tagging node:6.14-alpine
Tagging node:6-alpine
Tagging node:boron-alpine

$ test/run.sh node:6.14.4-alpine
testing node:6.14.4-alpine
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:6.14.4-onbuild
Using bashbrew/cache:74b548a77c2f09fbb2113dd186f1c9cfa4e99b283d3a73b5f8665e877fd98f77 (node:6.14.4-onbuild)
Tagging node:6.14.4-onbuild
Tagging node:6.14-onbuild
Tagging node:6-onbuild
Tagging node:boron-onbuild

$ test/run.sh node:6.14.4-onbuild
testing node:6.14.4-onbuild
	'override-cmd' [1/1]...passed


$ bashbrew build node:6.14.4-slim
Using bashbrew/cache:1e76d6b9418cf612d00c1b5c588e444a832313556fd928ee0aeeb41c1b39cd09 (node:6.14.4-slim)
Tagging node:6.14.4-slim
Tagging node:6.14-slim
Tagging node:6-slim
Tagging node:boron-slim

$ test/run.sh node:6.14.4-slim
testing node:6.14.4-slim
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:6.14.4-stretch
Using bashbrew/cache:28277676f7e9a830000bc5069863d93ff762c156e7addb0070526279a6fc93a2 (node:6.14.4-stretch)
Tagging node:6.14.4-stretch
Tagging node:6.14-stretch
Tagging node:6-stretch
Tagging node:boron-stretch

$ test/run.sh node:6.14.4-stretch
testing node:6.14.4-stretch
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:11.0.0-alpine
Using bashbrew/cache:61eb48cda77e75164bf5d2deae8836ca72b1267f03e35df10265b56d31265b0d (node:11.0.0-alpine)
Tagging node:11.0.0-alpine
Tagging node:11.0-alpine
Tagging node:11-alpine
Tagging node:alpine

$ test/run.sh node:11.0.0-alpine
testing node:11.0.0-alpine
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:11.0.0-slim
Building bashbrew/cache:d5c41e4049b197e57da78191cb1e90e73e49f70c585da59dcc64552f07278196 (node:11.0.0-slim)
Tagging node:11.0.0-slim
Tagging node:11.0-slim
Tagging node:11-slim
Tagging node:slim

$ test/run.sh node:11.0.0-slim
testing node:11.0.0-slim
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:11.0.0-stretch
Using bashbrew/cache:68f16b7c22fb9990322f148aa68573ff3ca5703ad2780ef87e3c85773f3e9a04 (node:11.0.0-stretch)
Tagging node:11.0.0-stretch
Tagging node:11.0-stretch
Tagging node:11-stretch
Tagging node:stretch
Tagging node:11.0.0
Tagging node:11.0
Tagging node:11
Tagging node:latest

$ test/run.sh node:11.0.0-stretch
testing node:11.0.0-stretch
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:10.13.0-jessie
Building bashbrew/cache:10b4d0e0b58cf41869e05c8b21f37b958a6500f7cb8c1b44a875433cb022b6a1 (node:10.13.0-jessie)
Tagging node:10.13.0-jessie
Tagging node:10.13-jessie
Tagging node:10-jessie
Tagging node:dubnium-jessie
Tagging node:10.13.0
Tagging node:10.13
Tagging node:10
Tagging node:dubnium

$ test/run.sh node:10.13.0-jessie
testing node:10.13.0-jessie
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:10.13.0-alpine
Building bashbrew/cache:e67fa433fd4a30001a0616e6a1d2c65c07c18faefee5792791a135f2bd797ca3 (node:10.13.0-alpine)
Tagging node:10.13.0-alpine
Tagging node:10.13-alpine
Tagging node:10-alpine
Tagging node:dubnium-alpine

$ test/run.sh node:10.13.0-alpine
testing node:10.13.0-alpine
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:10.13.0-slim
Building bashbrew/cache:9158a699d602fcca68a003c27e6c37621aa0b4b1edfbfaca8f0437223747834e (node:10.13.0-slim)
Tagging node:10.13.0-slim
Tagging node:10.13-slim
Tagging node:10-slim
Tagging node:dubnium-slim

$ test/run.sh node:10.13.0-slim
testing node:10.13.0-slim
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:10.13.0-stretch
Building bashbrew/cache:740bc4639119b9a446a88799ab8e383044678b6c1b96e9a9ee7b83b8562f9c08 (node:10.13.0-stretch)
Tagging node:10.13.0-stretch
Tagging node:10.13-stretch
Tagging node:10-stretch
Tagging node:dubnium-stretch

$ test/run.sh node:10.13.0-stretch
testing node:10.13.0-stretch
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:chakracore-8.11.1
Using bashbrew/cache:87de9f64cd61c5db496fd19fd8ee17dfe7d471cd57a9288ecf3fef0cf600f914 (node:chakracore-8.11.1)
Tagging node:chakracore-8.11.1
Tagging node:chakracore-8.11
Tagging node:chakracore-8

$ test/run.sh node:chakracore-8.11.1
testing node:chakracore-8.11.1
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:chakracore-10.6.0
Using bashbrew/cache:d9d66ef727c71a01a9706dd151000960f366e50699c8d16f252398d8ef364bc8 (node:chakracore-10.6.0)
Tagging node:chakracore-10.6.0
Tagging node:chakracore-10.6
Tagging node:chakracore-10
Tagging node:chakracore

$ test/run.sh node:chakracore-10.6.0
testing node:chakracore-10.6.0
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed

PeterDaveHello · 2018-11-02T04:17:23Z

Looks good!

Peter ~ $ for tag in 10.13.0 11.0.0 ; do docker pull node:$tag ; done
10.13.0: Pulling from library/node
61be48634cb9: Pull complete 
fa696905a590: Pull complete 
b6dd2322bbef: Pull complete 
32477089adb4: Pull complete 
febe7209ec28: Pull complete 
4364cbe57162: Pull complete 
529b9fcd8a55: Pull complete 
d5ca2d5eff34: Pull complete 
Digest: sha256:51bbebc2448556864de739a0c503aa9ac78798e1ae62a38de6ba6ed758e1cbf6
Status: Downloaded newer image for node:10.13.0
11.0.0: Pulling from library/node
bc9ab73e5b14: Pull complete 
193a6306c92a: Pull complete 
e5c3f8c317dc: Pull complete 
a587a86c9dcb: Pull complete 
72744d0a318b: Pull complete 
ae625339181e: Pull complete 
c25b903bb862: Pull complete 
a51c020843e8: Pull complete 
f5fd35b7fb44: Pull complete 
Digest: sha256:e02c9963a48fe3b7e134ebfaf8aca75fef7f4988234c8c48aa84ec9294d35942
Status: Downloaded newer image for node:11.0.0


Peter ~ $ for tag in 10.13.0 11.0.0 ; do docker pull node:$tag-alpine ; done
10.13.0-alpine: Pulling from library/node
4fe2ade4980c: Pull complete 
e4ac5f64a73e: Pull complete 
f62e97d98767: Pull complete 
Digest: sha256:44e21b14877bdb7375af498437fac4c93392bf4a500696ef17bd216b4fffcb58
Status: Downloaded newer image for node:10.13.0-alpine
11.0.0-alpine: Pulling from library/node
4fe2ade4980c: Already exists 
4fe6fc3d4500: Pull complete 
d48fd3011df1: Pull complete 
Digest: sha256:9df9329306194c156863c74e97e43b54aee3884940b971e87c5c1db2f82c766a
Status: Downloaded newer image for node:11.0.0-alpine

Peter ~ $ docker images
REPOSITORY          TAG                 IMAGE ID            CREATED             SIZE
node                10.13.0-alpine      e35872f034fd        4 hours ago         70.2 MB
node                10.13.0             5432ebbc244b        5 hours ago         674 MB
node                11.0.0              ad73966fd12e        5 hours ago         894 MB
node                11.0.0-alpine       5d526f8ba00b        5 hours ago         71.1 MB

PeterDaveHello mentioned this pull request Oct 24, 2018

Add node.js v11.0.0 with Yarn v1.10.1 nodejs/docker-node#881

Merged

docker-library-bot added the library/node label Oct 24, 2018

tianon reviewed Oct 29, 2018

View reviewed changes

This was referenced Oct 30, 2018

Create tags for Docker [Node 11] nodejs/docker-node#884

Closed

Add "naughty-from.sh" script inspired by the report of the same name #5007

Merged

pathmapper mentioned this pull request Oct 30, 2018

Remove node v9 from appveyor and update readme maplibre/maputnik#446

Merged

PeterDaveHello force-pushed the update-nodejs branch from fba1527 to 8b0e1c3 Compare October 30, 2018 16:19

PeterDaveHello changed the title ~~Add node v11.0.0~~ Add nodejs v11, update nodejs v10, and remove unsupported architectures Oct 30, 2018

PeterDaveHello changed the title ~~Add nodejs v11, update nodejs v10, and remove unsupported architectures~~ Add nodejs v11 and remove unsupported architectures Oct 30, 2018

knksmith57 mentioned this pull request Oct 30, 2018

feat: add Dubnium LTS tag to 10.x, mark 11.x as latest nodejs/docker-node#888

Merged

PeterDaveHello changed the title ~~Add nodejs v11 and remove unsupported architectures~~ [WIP] Add nodejs v11 and remove unsupported architectures Oct 31, 2018

Remove node i386 support from binary-release-based 10 variants

6ccedfd

PeterDaveHello force-pushed the update-nodejs branch from 8b0e1c3 to 40d7a71 Compare November 1, 2018 03:53

PeterDaveHello changed the title ~~[WIP] Add nodejs v11 and remove unsupported architectures~~ Add nodejs v11, update v10, remove unsupported architectures & variations Nov 1, 2018

PeterDaveHello changed the title ~~Add nodejs v11, update v10, remove unsupported architectures & variations~~ [WIP] Add nodejs v11, update v10, remove unsupported architectures & variations Nov 1, 2018

PeterDaveHello mentioned this pull request Nov 1, 2018

Switch Debian based image templates to Debian Stretch nodejs/docker-node#887

Merged

timbru31 mentioned this pull request Nov 1, 2018

any eta for 10.13 image to be published in dockerhub? nodejs/docker-node#892

Closed

PeterDaveHello added 5 commits November 2, 2018 03:49

Remove node "jessie" variations from unsupported architectures

c0f5eeb

Add node.js v11.0.0

2857165

- nodejs/docker-node#881 - https://github.com/nodejs/node/releases/tag/v11.0.0 - https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V11.md

Update node.js v10.x to v10.3.0

36768bc

Add node.js Dubnium LTS tag to 10.x, mark v11.x as latest

6438242

Temporily remove unsupported architectures in node.js

fe942eb

PeterDaveHello force-pushed the update-nodejs branch from 40d7a71 to fe942eb Compare November 1, 2018 19:58

PeterDaveHello changed the title ~~[WIP] Add nodejs v11, update v10, remove unsupported architectures & variations~~ Add nodejs v11, update v10, remove unsupported architectures & variations Nov 1, 2018

richardlau mentioned this pull request Nov 1, 2018

10.13.0 is not available on dockerhub nodejs/node#24018

Closed

tianon merged commit 1e7a9eb into docker-library:master Nov 1, 2018

PeterDaveHello deleted the update-nodejs branch November 2, 2018 04:06

Add nodejs v11, update v10, remove unsupported architectures & variations #4986

Add nodejs v11, update v10, remove unsupported architectures & variations #4986

Uh oh!

Conversation

PeterDaveHello commented Oct 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yosifkit commented Oct 24, 2018

Uh oh!

yosifkit commented Oct 25, 2018

Uh oh!

PeterDaveHello commented Oct 26, 2018

Uh oh!

holm commented Oct 26, 2018

Uh oh!

yosifkit commented Oct 26, 2018

Uh oh!

PeterDaveHello commented Oct 27, 2018

Uh oh!

tianon commented Oct 29, 2018

Uh oh!

tianon Oct 29, 2018

Choose a reason for hiding this comment

Uh oh!

PeterDaveHello Oct 30, 2018

Choose a reason for hiding this comment

Uh oh!

tianon Oct 30, 2018

Choose a reason for hiding this comment

Uh oh!

PeterDaveHello commented Oct 30, 2018

Uh oh!

tianon commented Oct 30, 2018

Uh oh!

PeterDaveHello commented Oct 31, 2018

Uh oh!

schmod commented Oct 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arnulfojr commented Oct 31, 2018

Uh oh!

chorrell commented Oct 31, 2018

Uh oh!

PeterDaveHello commented Oct 31, 2018

Uh oh!

PeterDaveHello commented Nov 1, 2018

Uh oh!

PeterDaveHello commented Nov 1, 2018

Uh oh!

PeterDaveHello commented Nov 1, 2018

Uh oh!

tianon commented Nov 1, 2018

Uh oh!

tianon commented Nov 1, 2018

Uh oh!

PeterDaveHello commented Nov 2, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

PeterDaveHello commented Oct 24, 2018 •

edited

Loading

schmod commented Oct 31, 2018 •

edited

Loading