Add a CONTRIBUTING.md file for n00bs like me #1089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianon
reviewed
Nov 24, 2020
Member
tianon
left a comment
tianon
left a comment
There was a problem hiding this comment.
This is great, thanks for figuring it out and taking a stab at writing some docs for it!
Just a few minor comments/suggestions 🙏
Author
|
Thanks for the review @tianon ! I think I've made all the requested changes. Happy to tweak any of it. |
TimWolla
reviewed
Nov 30, 2020
Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Dec 17, 2020
Changes: - docker-library/php@4908ef2: Remove 7.2 (EOL) - docker-library/php@20ebff4: Merge pull request docker-library/php#1089 from q0rban/add-contributing-md
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Dec 18, 2020
Changes: - docker-library/php@3db7191: Merge pull request docker-library/php#1104 from infosiftr/debian-cli-sapi - docker-library/php@73ccb45: Add "--enable-embed" to Debian-based CLI variants - docker-library/php@4908ef2: Remove 7.2 (EOL) - docker-library/php@20ebff4: Merge pull request docker-library/php#1089 from q0rban/add-contributing-md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.