Skip to content

Explicitly empty ~/.cache#103

Merged
tianon merged 1 commit intodocker-library:masterfrom
mattrobenolt:slimmer
Apr 19, 2016
Merged

Explicitly empty ~/.cache#103
tianon merged 1 commit intodocker-library:masterfrom
mattrobenolt:slimmer

Conversation

@mattrobenolt
Copy link
Contributor

This shaves off ~1.1MB off the container builds. We do --no-cache-dir on
pip install, but turns out, this isn't enough. Stuff from within
get-pip.py ends up leveraging the http cache as well, so we should
just nuke it entirely.

@yosifkit
Copy link
Member

Oh pip... 😞 LGTM

@tianon
Copy link
Member

tianon commented Apr 19, 2016

Can we use ~/.cache instead just to help insulate ourselves a tiny bit from HOME screwiness? 😇

@mattrobenolt
Copy link
Contributor Author

Can we use ~/.cache instead just to help insulate ourselves a tiny bit from HOME screwiness? 😇

Is it possible that it'd be built while running under a different user? I'm not against the change, just curious why that scenario may happen.

This shaves off ~1.1MB off the container builds. We do --no-cache-dir on
`pip install`, but turns out, this isn't enough. Stuff from within
`get-pip.py` ends up leveraging the http cache as well, so we should
just nuke it entirely.
@mattrobenolt mattrobenolt changed the title Explicitly empty /root/.cache Explicitly empty ~/.cache Apr 19, 2016
@mattrobenolt
Copy link
Contributor Author

Updated to use ~ instead of /root

@tianon
Copy link
Member

tianon commented Apr 19, 2016 via email

@tianon
Copy link
Member

tianon commented Apr 19, 2016

You were faster than GitHub's email to comment gateway 😆

LGTM, thanks 👍

@tianon tianon merged commit 6452851 into docker-library:master Apr 19, 2016
@mattrobenolt mattrobenolt deleted the slimmer branch April 20, 2016 00:00
tianon added a commit to infosiftr/stackbrew that referenced this pull request Apr 20, 2016
- `drupal`: 8.1 GA
- `mariadb`: add xtrabackup for Galera (MariaDB/mariadb-docker#47)
- `pypy`: 5.1.0
- `python`: empty `~/.cache` (docker-library/python#103)
- `redis`: use `su-exec` in Alpine variants (redis/docker-library-redis#54)
- `rocket.chat`: 0.27.0
RichardScothern pushed a commit to RichardScothern/official-images that referenced this pull request Jun 14, 2016
- `drupal`: 8.1 GA
- `mariadb`: add xtrabackup for Galera (MariaDB/mariadb-docker#47)
- `pypy`: 5.1.0
- `python`: empty `~/.cache` (docker-library/python#103)
- `redis`: use `su-exec` in Alpine variants (redis/docker-library-redis#54)
- `rocket.chat`: 0.27.0
JayH5 added a commit to praekeltfoundation/docker-alpine-python that referenced this pull request Jul 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments