Alpine: add tk as build dependency#130
Merged
yosifkit merged 1 commit intodocker-library:masterfrom Jul 21, 2016
Merged
Conversation
Member
|
Aha, very nice catch! LGTM |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #127,
tcl-devandtk-devwere added as build dependencies so that thetkintermodule could be built.Unfortunately, the Alpine Linux
tk-devpackage doesn't include the actualtklibraries (only the headers) so thetkintermodule still fails to build. Thetkpackage does include the relevant libraries. This is just an issue with the Alpine packages that should probably be fixed upstream (tk-devshould maybe depend ontk).From the Travis logs for #127 for
python:2.7-alpine:From the Travis logs for #127 for
python:2.7-docker:From the Travis logs for this PR, after adding the
tkpackage forpython:2.7-alpine:This is a fairly obscure issue and I doubt many people (I am not one of them) are using
tkinteron the Alpine images. I just had somehow had this issue with these packages before. Without this change the installation oftcl-devandtk-devis effectively not doing anything.