Add Python 3.7/alpine3.8#303
Closed
tao12345666333 wants to merge 3 commits intodocker-library:masterfrom
Closed
Conversation
Closed
Contributor
Author
|
The Alpine 3.8 image has been available. Updated |
Contributor
|
You'll need #304 and to update diff --git a/update.sh b/update.sh
index 11683d6..7f53640 100755
--- a/update.sh
+++ b/update.sh
@@ -112,7 +112,7 @@ for version in "${versions[@]}"; do
echo "$version: $fullVersion"
for v in \
- alpine{3.6,3.7} \
+ alpine{3.6,3.7,3.8} \
{wheezy,jessie,stretch}{/slim,/onbuild,} \
windows/nanoserver-{1709,sac2016} \
windows/windowsservercore-{1709,ltsc2016} \
@@ -154,8 +154,8 @@ for version in "${versions[@]}"; do
esac
# https://bugs.python.org/issue32598 (Python 3.7.0b1+)
- # TL;DR: Python 3.7+ uses OpenSSL functionality which LibreSSL doesn't implement (yet?)
- if [[ "$version" == 3.7* ]] && [[ "$variant" == alpine* ]]; then
+ # TL;DR: Python 3.7+ uses OpenSSL functionality which LibreSSL 2.6 in Alpine 3.7 doesn't implement
+ if [[ "$version" == 3.7* ]] && [[ "$variant" == alpine3.7 ]]; then
sed -ri -e 's/libressl/openssl/g' "$dir/Dockerfile"
fi
A Python 2.7/Alpine 3.8 image would be cool too 🙋🏼♂️ |
Contributor
Author
|
@JayH5 Thanks. I have updated it. |
lorddaedra
suggested changes
Jul 12, 2018
| # TL;DR: Python 3.7+ uses OpenSSL functionality which LibreSSL doesn't implement (yet?) | ||
| if [[ "$version" == 3.7* ]] && [[ "$variant" == alpine* ]]; then | ||
| # TL;DR: Python 3.7+ uses OpenSSL functionality which LibreSSL 2.6.x in Alpine 3.7 doesn't implement | ||
| if [[ "$version" == 3.7* ]] && [[ "$variant" == alpine3.7 ]]; then |
There was a problem hiding this comment.
Should be alpine3.8 instead of alpine3.7, isn't it?
Contributor
Author
There was a problem hiding this comment.
@lorddaedra It isn't. On alpine3.8 we can use libressl , the package's version is 2.7.x.
There was a problem hiding this comment.
looks like, you are right...
then we should merge this PR...
do we have any reasons to wait for anything?..
|
Can we have also python 3.6 with alpine 3.8 ? |
Contributor
Author
|
@pvizeli Yes, we can. |
Member
|
#311 👍
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Alpine 3.8 and change openssl to libressl. Because Alpine 3.8 updated libressl to 2.7.4-r0 which Python 3.7's
sslmodule can compatible with it.Now the official Alpine 3.8 is not not available. gliderlabs/docker-alpine#418
So I build one Alpine 3.8 image locally and test this change.
After the Alpine 3.8 image be available, I will change
.travis.ymlFixes #300