Set LANG by default #320
Merged
Set LANG by default #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@tianon What do you think? |
mtsmfm
force-pushed
the
set-lang-by-default
branch
from
ed6359c to
6d8b595
Compare
Contributor
Author
|
I've fixed conflict and force-pushed |
Contributor
Author
|
It seems failed tests are not related to this PR. -> It's fixed by bundler-audit 0.7.1 |
mtsmfm
force-pushed
the
set-lang-by-default
branch
from
6d8b595 to
eb00d86
Compare
Member
|
Thanks! This seems fine to me. I didn't notice that upstream was even making their own images; thanks for pointing them out 🤘. |
tianon
reviewed
Jun 24, 2020
Ruby docker images officially provided by ruby-lang.org set `LANG` as `C.UTF-8` by default. https://hub.docker.com/r/rubylang/ruby/ https://github.com/ruby/ruby-docker-images/blob/36c5d8b68eb91e34825500e50ca677f5574401f7/Dockerfile#L3 docker-library#45 (comment) > I'd rather see something more official from either Ruby or Rails upstreams > recommending a UTF-8 locale by default than just the anecdote that it's > "more common" or "more convenient". I think it's the one so we should set it by default.
mtsmfm
force-pushed
the
set-lang-by-default
branch
from
eb00d86 to
8e49e25
Compare
Contributor
Author
Member
|
Thanks! |
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Jun 25, 2020
Changes: - docker-library/ruby@8813cdd: Merge pull request docker-library/ruby#320 from mtsmfm/set-lang-by-default - docker-library/ruby@8e49e25: Set LANG by default
bquorning
added a commit
to rubocop/circleci-ruby-snapshot-image
that referenced
this pull request
Jul 17, 2020
With changes from docker-library/ruby#320
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby docker images officially provided by ruby-lang.org set
LANGasC.UTF-8by default.https://hub.docker.com/r/rubylang/ruby/
https://github.com/ruby/ruby-docker-images/blob/36c5d8b68eb91e34825500e50ca677f5574401f7/Dockerfile#L3
#45 (comment)
I think it's the one so we should set it by default.