Add ruby 3.0.0-preview1 #326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianon
reviewed
Sep 28, 2020
| declare -A newEnoughRubygems=( | ||
| [2.6]=1 # 2.6.3 => gems 3.0.3 (https://github.com/ruby/ruby/blob/v2_6_3/lib/rubygems.rb#L12) | ||
| [2.7]=1 # 2.7.0-preview2 => gems 3.1.0.pre1 (https://github.com/ruby/ruby/blob/v2_7_0_preview1/lib/rubygems.rb#L12) | ||
| [3.0]=1 # 3.0.0-preview1 => gems 3.2.0.rc.1 (https://github.com/ruby/ruby/blob/v3_0_0_preview1/lib/rubygems.rb#L11) |
Member
There was a problem hiding this comment.
This is verbatim what I have in my local working directory where I was experimenting with making this change. 😅 😍
tianon
reviewed
Sep 28, 2020
3.0-rc/alpine3.11/Dockerfile
Outdated
| @@ -0,0 +1,130 @@ | |||
| FROM alpine:3.11 | |||
Member
There was a problem hiding this comment.
This file should be dropped completely -- we don't support newer releases on older base operating systems unless there's a really compelling reason to do so (and for Alpine 3.11 vs 3.12, there isn't a strong one we've seen).
tianon
added a commit
to docker-library/official-images
that referenced
this pull request
Sep 28, 2020
Member
|
Nice, looks great, thank you! 👍 |
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Sep 28, 2020
Changes: - docker-library/ruby@0555f85: Merge pull request docker-library/ruby#326 from sdwolfz/ruby-3 - docker-library/ruby@57a8df4: Add ruby 3.0.0-preview1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied the files over from 2.7 and changed the versions and sha to be:
Not sure what the change in
update.shis supposed to be, but I followed the pattern anyway. Fingers crossed it works 🤞 .Official release announcement:
Needs this change to pass tests: