buildkit: add types #359
Merged
buildkit: add types #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds BuildKit types that will be used in #302 (related to docker/buildx#2511) and #347.
Atm these types are manually crafted based on generated proto from BuildKit repository:
In follow-up we should generate these types with a tool like https://github.com/stephenh/ts-proto.
@nico1510 @austin5456 let me know if this is something that could be used on DD side by either using the actions-toolkit module: https://www.npmjs.com/package/@docker/actions-toolkit or having a dedicated one like
@types/buildkitin https://github.com/DefinitelyTyped/DefinitelyTyped.