Skip to content

Conversation

@crazy-max
Copy link
Member

No description provided.

@tonistiigi
Copy link
Member

CI looks red

@crazy-max
Copy link
Member Author

Ah yes the canonical representation of the bake definition now adds network: null since Buildx 0.17.0:

 #20 22.15     expect(received).toEqual(expected) // deep equality
#20 22.15 
#20 22.15     - Expected  - 0
#20 22.15     + Received  + 1
#20 22.15 
#20 22.15     @@ -12,9 +12,10 @@
#20 22.15               "BUILDKIT_CONTEXT_KEEP_GIT_DIR": "1",
#20 22.15               "GO_VERSION": "1.20",
#20 22.15             },
#20 22.15             "context": ".",
#20 22.15             "dockerfile": "Dockerfile",
#20 22.15     +       "network": null,
#20 22.15             "target": "build",
#20 22.15           },
#20 22.15         },
#20 22.15       }

@crazy-max
Copy link
Member Author

Opened docker/buildx#2689 to fix that

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@tonistiigi tonistiigi merged commit 49c5ada into docker:main Sep 13, 2024
@crazy-max crazy-max deleted the update-buildx branch September 13, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants