docker(install): set missing XDG_RUNTIME_DIR env #763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvoland
approved these changes
Aug 8, 2025
vvoland
reviewed
Aug 8, 2025
src/docker/install.ts
Outdated
| const envs = Object.assign({}, process.env, { | ||
| PATH: `${this.toolDir}:${process.env.PATH}`, | ||
| XDG_RUNTIME_DIR: (this.rootless && this.runDir) || undefined | ||
| XDG_RUNTIME_DIR: (this.rootless && this.runDir) || process.env.XDG_RUNTIME_DIR |
Contributor
There was a problem hiding this comment.
This doesn't hurt, but actually it shouldn't even get to that point if runDir is not set?
actions-toolkit/src/docker/install.ts
Lines 233 to 235 in 70344da
Member
Author
There was a problem hiding this comment.
Ah yes indeed, I'm reverting this change
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
docker-install-xdg
branch
from
37991d7 to
7f3d74b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #760