-
Notifications
You must be signed in to change notification settings - Fork 617
docs: add new kubernetes build driver docs #1208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Jul 12, 2022
AkihiroSuda
reviewed
Jul 12, 2022
AkihiroSuda
reviewed
Jul 12, 2022
35f99f6 to
7aadb57
Compare
AkihiroSuda
approved these changes
Jul 13, 2022
crazy-max
reviewed
Jul 13, 2022
crazy-max
requested changes
Jul 13, 2022
Member
crazy-max
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small typo, otherwise lgtm
Signed-off-by: Justin Chadwell <me@jedevc.com>
7aadb57 to
900f356
Compare
crazy-max
approved these changes
Jul 18, 2022
Member
crazy-max
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new kubernetes builder guide to match the remote builder guide previously added in #1093.
The content consolidates some of the information already present in the command line reference, and discussions like #685.
I think this should be a good first pass of the guide, we might want to follow-up and add some more complex deployment scenarios, though I'm not as familiar with those, so will likely leave them to someone with some more experience there 😄