Support new tar option for oci+docker exporters#1420
Merged
crazy-max merged 3 commits intodocker:masterfrom Nov 29, 2022
Merged
Support new tar option for oci+docker exporters#1420crazy-max merged 3 commits intodocker:masterfrom
tar option for oci+docker exporters#1420crazy-max merged 3 commits intodocker:masterfrom
Conversation
crazy-max
requested changes
Nov 23, 2022
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
crazy-max
approved these changes
Nov 28, 2022
Member
|
Get this one in, as follow-up we should have unit tests for this package: https://github.com/docker/buildx/blob/master/util/buildflags |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⬆️ Follow-up to moby/buildkit#3162
moby/buildkit#3162 requires changes to buildx, as it requires improved validation in the CLI to correctly determine whether it should pass a file or a directory to the buildkit server. Additionally, we need to update the buildkit vendored packages for the updated client-side validation.