Add FOSSA checks to Jenkins CI#144
Merged
tiborvass merged 1 commit intodocker:masterfrom Sep 17, 2019
Merged
Conversation
droopy4096
changed the title
zelahi
suggested changes
Sep 13, 2019
Contributor
zelahi
left a comment
zelahi
left a comment
There was a problem hiding this comment.
Small knitpicks and a change that I should have pointed out earlier. Apologies for not doing so, but we made the fossa-analyzer public now. So we don't have to use the orca creds and pull from the dockereng org. It's mostly so we don't have our secrets in the public repos
Collaborator
|
Is this makefile a generic makefile you have in other repos? I'm asking because it is not using any Makefile specifics, so it might as well be a simple shell script that could be put in |
Contributor
Author
|
that is correct - that's the boilerplate Makefile we've used in other places. We're working on improvements - this is our first "fast" iteration to get FOSSA coverage across the board. |
tiborvass
reviewed
Sep 17, 2019
tiborvass
reviewed
Sep 17, 2019
tiborvass
reviewed
Sep 17, 2019
tiborvass
previously approved these changes
Sep 17, 2019
Signed-off-by: Dmytro Makovey <dmytro.makovey@docker.com> Signed-off-by: Tibor Vass <tibor@docker.com>
tiborvass
changed the title
tiborvass
approved these changes
Sep 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.