bake: allow pattern matching for target names in --set#164
Merged
tonistiigi merged 3 commits intodocker:masterfrom Apr 23, 2020
Merged
bake: allow pattern matching for target names in --set#164tonistiigi merged 3 commits intodocker:masterfrom
tonistiigi merged 3 commits intodocker:masterfrom
Conversation
tiborvass
force-pushed
the
multitarget-set
branch
from
99921b2 to
d6f9e90
Compare
Contributor
|
I've been waiting for this for so long. |
tiborvass
force-pushed
the
multitarget-set
branch
from
d6f9e90 to
1e3c6a0
Compare
Member
|
@tiborvass CI red |
tiborvass
force-pushed
the
multitarget-set
branch
from
f3b41f5 to
70209e1
Compare
Collaborator
Author
|
Updated with a dependent bugfix in #259 |
tonistiigi
approved these changes
Apr 23, 2020
added 3 commits
April 23, 2020 05:54
Although bake is for running multiple targets, --set required a single target name for overriding a property. This change allows matching multiple targets for overrides. Signed-off-by: Tibor Vass <tibor@docker.com>
Signed-off-by: Tibor Vass <tibor@docker.com>
Signed-off-by: Tibor Vass <tibor@docker.com>
tiborvass
force-pushed
the
multitarget-set
branch
from
70209e1 to
078b659
Compare
|
@tonistiigi are there any plans to support both, |
Member
|
@ChrisBr Yes, but it needs a buildkit update to support multiple exporters. |
|
Awesome @tonistiigi, thanks for your response. So is this already supported in Buildkit or needs to be implemented there as well? Sorry for my naive question, we just stumbled upon this earlier and expected we could export and push at the same time. Also happy to have a look if there is already an issue to be worked on etc. |
Member
|
@ChrisBr No, there is an old PR moby/buildkit#1788 that got stuck and needs to be picked up or reimplemented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although bake is for running multiple targets, --set required a single
target name for overriding a property. This change allows matching
multiple targets for overrides.
bake: add --load and --push shorthands for --set