build: remove buildinfo #1702
Closed
build: remove buildinfo #1702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BuildKit v0.11 has deprecated buildinfo, and BuildKit v0.12 will remove it, so we should remove it from Buildx as well. Signed-off-by: Justin Chadwell <me@jedevc.com>
Collaborator
Author
|
woops, have just seen #1681 🤦 |
Member
Looks like this PR removes things that are not removed in that other PR? Should those still be removed? |
Collaborator
Author
|
Yeah, we shouldn't remove them, we still need to keep doing them 🤦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⬆️ Follow up moby/buildkit#3582.
BuildKit v0.11 has deprecated buildinfo, and BuildKit v0.12 will remove it, so we should remove it from Buildx as well.
We may want to hold on merging this until we vendor the next release of BuildKit - not exactly sure on release timing.