build: support for saving local state by build ref #1735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
crazy-max
reviewed
Apr 13, 2023
crazy-max
approved these changes
Apr 13, 2023
jedevc
reviewed
Apr 14, 2023
crazy-max
reviewed
Apr 24, 2023
Comment on lines
+1650
to
+1651
| LocalPath: lp, | ||
| DockerfilePath: dp, |
Member
There was a problem hiding this comment.
Suggested change
| LocalPath: lp, | |
| DockerfilePath: dp, | |
| LocalPath: filepath.ToSlash(lp), | |
| DockerfilePath: filepath.ToSlash(dp), |
Member
Author
There was a problem hiding this comment.
We do want this to be the actual path that can be looked up from the system. If we do ToSlash then it might not be possible to get back the original path.
crazy-max
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some build parameters like directory paths, are never sent to buildkit. But it may still make sense to store them and associate with a unique ref for a build that is used to track other parameters on buildkit side.
@crazy-max