test: relax validation of TEST_BUILDKIT_IMAGE to reduce direct dependencies #1818
Conversation
…encies commit 2d124e0 added some integration-tests, and as part of those tests added github.com/distribution/distribution/v3 as a direct dependency. github.com/distribution/distribution/v3 is unreleased, and is still receiving backward breaking changes. While this dependency is already used elsewhere, it looks like the only use in buildx was for a sanity check of the custom TEST_BUILDKIT_IMAGE; we can probably relax that check to avoid adding the direct dependency. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
| buildkitImage = ref.String() | ||
| } | ||
| if img, ok := os.LookupEnv("TEST_BUILDKIT_IMAGE"); ok && img != "" { | ||
| t.Log("using TEST_BUILDKIT_IMAGE", img) |
There was a problem hiding this comment.
Not sure if needed, but thought to make it more visible if a custom image is used, in that odd case an invalid image reference is passed.
|
@jedevc @tonistiigi PTAL (let me know if you feel strongly about this; the alternative was to use the same version as BuildKit (v2.8.2), but when looking what it was used for, it seemed a very minimal "added value" |
|
This looks fine but how does it matter if it is a direct or indirect dependency? Looks like this came from latest compose update. We can also just use the regular |
|
Ugh, that's frustrating. Yeah, I 100% meant to use docker/distribution, which we already use in other places in the codebase, have opened an alternative PR to update that. |
3 participants
commit 2d124e0 (#1770) added some integration-tests, and as part of those tests added github.com/distribution/distribution/v3 as a direct dependency.
github.com/distribution/distribution/v3 is unreleased, and is still receiving backward breaking changes. While this dependency is already used elsewhere, it looks like the only use in buildx was for a sanity check of the custom TEST_BUILDKIT_IMAGE; we can probably relax that check to avoid adding the direct dependency.