bake: fix incorrect dockerfile resolution against cwd:// context
#1880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to resolve the strip the cwd:// prefix before attempting to resolve the dockerfile. Otherwise, we'll get the cwd:// prefix in the dockerfile name, which isn't stripped out later. Signed-off-by: Justin Chadwell <me@jedevc.com>
crazy-max
approved these changes
Jun 14, 2023
Member
|
I think the old behavior is intentional. It is for the use case where you have docker build logic only in the remote repository and source files in local dir. In that case, the Dockerfile and Bake file are stored together (similar to using If someone can prove this is a regression that would change things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Fixes #1627
We need to resolve the strip the
cwd://prefix before attempting to resolve the dockerfile. Otherwise, we'll get thecwd://prefix in the dockerfile name, which isn't stripped out later.Also added this to the test case, where previously we would get a
cwd://in the dockerfile name, now we correctly resolve it.